php singleton object not created

Question

I'm trying to learn about OOP, and create a singleton to return a settings object within a PHP script. For some reason, the instance never seems to get set.

I'm echoing a message getting settings anytime the singleton goes through its construct (it's silent if it just returns the existing instance).

When this is called from within a script, I'm getting dozens of these getting settings messages, one for each time I call mySettings::getSettings()-- $instance doesn't seem to be created, even when I try to dump it immediately after it is created.

Can anyone point out where I'm going wrong?

Here's the code:

class mySettings {
    private $settings;
    private static $instance;

    private function __construct(){
        $configfile = "myconfig.ini";
        if(!$this->settings = parse_ini_file( $configfile )){
            die('CONFIG NOT FOUND/PARSED');
        }
    }

    public static function getSettings(){
        if ( !self::$instance ){
            echo "getting settings-- no instance found!";
            self::$instance = new mySettings();
            var_dump(self::$instance); // <-- dumps nothing
        }
        return self::$instance;
    }

    public function setParam( $key, $value ){
        $this->settings[$key] = $value;
    }

    public function getParam( $key ){
        return $this->settings[$key];
    }
}

@julio, webbiedave and i both got it to work right. perhaps something elsewhere (outside of that class) is going wrong. — Kristian
– Kristian, Commented May 10, 2012 at 17:22
thanks for the help guys. I'll update with the other functions that could be the issue and take a look at those. — julio
– julio, Commented May 10, 2012 at 17:25
Code works completely. I think the error is somewhere else. Could you show your real code? — Shiplu Mokaddim
– Shiplu Mokaddim, Commented May 10, 2012 at 17:38

ilanco · Accepted Answer · 2012-05-10 17:14:27Z

1

Your approach to creating a singleton looks correct.

Try with an empty constructor, there might be an issue with that die() statement there.

answered May 10, 2012 at 17:14

ilanco

10.1k4 gold badges34 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kristian Over a year ago

if it were dying, it would say the die message, wouldn't it?

julio Over a year ago

@Kristian-- yes, in fact the die statement is operational, if I give a bad path or an empty value for the config file, it will die. Also, if I dump the value returned by $var = mySettings::getSettings() elsewhere, it does have the expected value.

Bob Fanger · Accepted Answer · 2012-05-12 19:40:48Z

0

Does: // <-- dumps nothing mean you see a "NULL" being rendered or nothing at all?

Maybe you've got some output buffering that hides the var_dump() output.

answered May 12, 2012 at 19:40

Bob Fanger

30k7 gold badges68 silver badges83 bronze badges

Collectives™ on Stack Overflow

php singleton object not created

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related