replace bytes in file c

Question

I got some code and I want improve it to find and replace bytes in file so I want to find all origbytes in FILE and then replace it with newbytes then save file, I know how to open, write and save, but hot I can find bytes in char?

 FILE* file;
 file = fopen("/Users/Awesome/Desktop/test", "r+b");
 int size = sizeof(file)+1;
 char bytes [size];
 fgets(bytes, size, file);
 for (int i=0; i<size; i++){ 
     char origbytes  []  = {0x00, 0x00};
     char newbytes   []  = {0x11, 0x11};
     if (strcmp(bytes[i], origbytes)) //Here the problem
     {
         fseek(file, i, SEEK_SET);
         fwrite(newbytes, sizeof(newbytes), 1, file);
     }
 }
 fclose(file);

As a reminder, if you have answers to your questions that are good, you should accept one. — crashmstr
– crashmstr, Commented May 14, 2012 at 12:42

Community · Accepted Answer · 2017-05-23 10:27:14Z

4

strcmp() is for string compare and not character compare. Two characters can be compared directly

if ( bytes[i] == origbytes[something] )

Also you you should not apply sizeof() on a file pointer to determine file size. You should seek to the end of file using fseek and then query ftell except for binary files. For binary files, use something like fstat

One more thing to note is that fgets returns much before the EOF if it sees a newline. Hence in your code, you may not read entire file contents even after doing the changes that we suggested. You need to use fread appropriately

edited May 23, 2017 at 10:27

CommunityBot

11 silver badge

answered May 14, 2012 at 12:41

Pavan Manjunath

28.9k12 gold badges110 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ash108 Over a year ago

Good answer. Only a small correction: actually the link to cert you gave recommends against using fseek/ftell for anything except new fseeks in the same file, both for binary and text files. So it's best to use fstat to get file size in any case.

Skizz · Accepted Answer · 2012-05-14 12:41:48Z

1

Strings are null terminated in the C standard library. Your search data is effectively a zero length string. You want memcmp instead.

memcmp (&bytes [i], origBytes, 2)

answered May 14, 2012 at 12:41

Skizz

71.4k10 gold badges75 silver badges109 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:59:02Z

1

Firstly sizeof(file) + 1 just returns you the size of a pointer + 1. I don't think you need this for the size of the file. Use this: How do you determine the size of a file in C? Then since you compare bytes (more or less smae as char) you simply compare using =

edited May 23, 2017 at 11:59

CommunityBot

11 silver badge

answered May 14, 2012 at 12:42

Ferenc Deak

35.6k19 gold badges107 silver badges176 bronze badges

Comments

behe · Accepted Answer · 2012-05-14 14:59:47Z

0

you can use fseek and then ftell functions to get the file size, not sizeof.

answered May 14, 2012 at 14:59

behe

1994 silver badges16 bronze badges

1 Comment

benzado Over a year ago

That's more accurate than sizeof, but less efficient. Better to just query the file system for the size directly.

Collectives™ on Stack Overflow

replace bytes in file c

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related