StackOverFlow error - from instantiating my object class

Question

I am trying to make a class in Java that builds an object of type Action which holds three ints and returns it to my other class in the array history, where history is an array of type Action. When it is called I immediately get an endless loop; hence the stack overflow.

Error - I printed 1 line, it goes on...

Exception in thread "main" java.lang.StackOverflowError
    at sudokugame.Action.<init>(Action.java:7)

Class:

public class Action {

    Action a;
    public Action(int i, int o, int p){
      a = new Action(i,o,p);
    }

    public void   setAction(int n, int b, int c){

    }

    public Action  getAction(){
        return a;
    }
}

Community · Accepted Answer · 2017-05-23 12:22:00Z

12

Your constructor calls itself recursively forever. A sure way to overflow a stack :)

public Action(int i, int o, int p){
    //why do you do this?
    a = new Action(i,o,p);
}

Maybe what you really wanted to do was just store i,o and p in the class instance?

public class Action {

  int i;
  int o;
  int p;

  public Action(int i, int o, int p){
    this.i = i;
    this.o = o;
    this.p = p;
  }

  ...
}

(edit: see other answer for fuller example)

edited May 23, 2017 at 12:22

CommunityBot

11 silver badge

answered Jun 30, 2009 at 13:12

Paul Dixon

302k54 gold badges315 silver badges349 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adrian Godong · Accepted Answer · 2009-06-30 13:15:20Z

3

Try doing it this way:

public class Action {

  int i;
  int o;
  int p;

  public Action(int i, int o, int p){
    this.i = i;
    this.o = o;
    this.p = p;
  }

  public void setAction(int n, int b, int c){
    this.i = i;
    this.o = o;
    this.p = p;
  }

  public Action getAction(){
    return this;
  }
}

answered Jun 30, 2009 at 13:15

Adrian Godong

8,9718 gold badges43 silver badges63 bronze badges

Comments

Andrew Hare · Accepted Answer · 2009-06-30 13:14:35Z

2

The problem is here:

a = new Action(i,o,p);

You are invoking the constructor again for a new instance inside the constructor of the class itself. Since each subsequent call to the constructor will create a new constructor call there is no way for the stack to unwind, therefore creating a stack overflow.

answered Jun 30, 2009 at 13:14

Andrew Hare

353k75 gold badges649 silver badges642 bronze badges

Comments

Jason Miesionczek · Accepted Answer · 2009-06-30 13:12:43Z

0

Your instantiating the class within itself.

answered Jun 30, 2009 at 13:12

Jason Miesionczek

14.5k17 gold badges80 silver badges111 bronze badges

1 Comment

David M Over a year ago

Why would this be a problem? The recursion is the problem here.

Jack Leow · Accepted Answer · 2009-06-30 13:15:14Z

0

Does your Action class really need to hold on to a reference to another Action?

Action a;

Specifically, is this line necessary? What are you using it for?

answered Jun 30, 2009 at 13:15

Jack Leow

22.6k4 gold badges54 silver badges60 bronze badges

Comments

nilesh · Accepted Answer · 2009-06-30 13:25:16Z

0

sure your constructor has recursive call.

answered Jun 30, 2009 at 13:25

nilesh

2,2753 gold badges16 silver badges11 bronze badges

Comments

Brian T. Grant · Accepted Answer · 2009-06-30 15:20:33Z

0

The Command design pattern is one way to approach a situation where you want to have a history of actions taken so they can be undone, etc.

answered Jun 30, 2009 at 15:20

Brian T. Grant

1871 silver badge3 bronze badges

Comments

Silent Warrior · Accepted Answer · 2009-07-01 06:13:08Z

0

Constructor have recursive call.

answered Jul 1, 2009 at 6:13

Silent Warrior

5,3038 gold badges43 silver badges53 bronze badges

Collectives™ on Stack Overflow

StackOverFlow error - from instantiating my object class

8 Answers 8

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related