Storing objects in an array with php

Question

I have a function that pulls rows from a database, the content->id and content->type are them used to dynamically call amethod in an already loaded model to get and format the objects details. Once the object is returned it is added to array. All is well except that when i come to use the array although it has the correct number of items in it, they all contain the same object even though i know that they are returned different. Im at a complete loss with this one, any help/ideas whould be great!

The code is below:

foreach($query->result() as $content)
{
    $item = $this->{'mod_'.$content->type}->get($content->id);
    print_r($item);
    $items[] = $item;
}
print_r($items);

And the print_r statements produce this:

stdClass Object
(
    [id] => 30
    [type] => page
)

stdClass Object
(
    [id] => 29
    [type] => page
)

Array
(
    [0] => stdClass Object
        (
            [id] => 29
            [type] => page
        )

    [1] => stdClass Object
        (
           [id] => 29
           [type] => page
        )

)

Is this a true copy paste of your code?

cgp
– cgp

2009-06-30 17:14:16 +00:00
Commented Jun 30, 2009 at 17:14 — cgp
– cgp, Commented Jun 30, 2009 at 17:14

Mikael Auno · Accepted Answer · 2009-07-07 15:34:31Z

13

I would guess that the problem is that you get to the same object every time by reference from the get function and then add it by reference to the array, resulting in all items in the array being modified when the item gets modified in the get function. If that is the case, the following should work:

foreach($query->result() as $content)
{
    $item = $this->{'mod_'.$content->type}->get($content->id);
    print_r($item);
    $items[] = clone $item;
}
print_r($items);

edited Jul 7, 2009 at 15:34

answered Jun 30, 2009 at 17:17

Mikael Auno

9,0902 gold badges23 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MoshiBin · Accepted Answer · 2009-06-30 17:18:55Z

4

When you push $item to $items, it doesn't push the value $item points to but rather the reference itself. You'll need to initialize $item each time:

foreach($query->result() as $content)
{
    $item = new stdClass();
    $item = $this->{'mod_'.$content->type}->get($content->id);
    print_r($item);
    $items[] = $item;
}
print_r($items);

answered Jun 30, 2009 at 17:18

MoshiBin

3,2062 gold badges23 silver badges24 bronze badges

2 Comments

Paul Dixon Over a year ago

I thought that something like this would be the problem but initializing it each time didnt work. $items[] = clone($item) did however

MoshiBin Over a year ago

On second examination it's easy to understand why this method won't work; $items is an array filled with $item, which is still a reference. Reinitializing $item means all items will still refer to the same object. As said above, clone() is the way :)

cgp · Accepted Answer · 2009-06-30 17:15:43Z

3

You are probably returning references to the item, not the items themselves. It will always the last reference that $item points to.

answered Jun 30, 2009 at 17:15

cgp

41.4k12 gold badges107 silver badges131 bronze badges

Collectives™ on Stack Overflow

Storing objects in an array with php

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related