Cannot add/remove attribute onclick

Question

I am new to javascript and jQuery. I am trying to add an attribute on click and remove it on click. I have add and remove class working well but not attribute. My code is below.

HTML below

<label class="label_check" for="fadv">
    <input class="lesson" id="fadv" value="acl323" name="fadv" checked="checked" type="checkbox" />Please send me regular updates.
</label>

jQuery below

<script>
function setupLabel() {
    if ($('.label_check input').length) {
        $('.label_check').each(function(){ 
            $(this).removeClass('c_on');
            $(this).removeAttr('pull');
        });
        $('.label_check input:checked').each(function(){ 
            $(this).parent('label').addClass('c_on');
            $(this).attr('pull' , 'on');
        });                
    };
};
$(document).ready(function(){
    $('body').addClass('has-js');
    $('.label_check, .label_radio').click(function(){
        setupLabel();
    });
    setupLabel();
});
</script>

Could you explain what you want to happen on clicking the checkbox? Or is it the label that should be the click-target? — David Thomas
– David Thomas, Commented May 18, 2012 at 11:53

Belladonna · Accepted Answer · 2012-05-20 17:08:34Z

1

Can you empty the attribute value?

function setupLabel() {
    if ($('.label_check input').length) {
        $('.label_check').each(function(){ 
            $(this).removeClass('c_on');
            $(this).attr('pull','');
        });
        $('.label_check input:checked').each(function(){ 
            $(this).parent('label').addClass('c_on');
            $(this).attr('pull' , 'on');
        });                
    };
};
$(document).ready(function(){
    $('body').addClass('has-js');
    $('.label_check, .label_radio').click(setupLabel);
    setupLabel();
});

edited May 20, 2012 at 17:08

answered May 18, 2012 at 22:05

Belladonna

3,8622 gold badges26 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

pomeh Over a year ago

function(){ setupLabel(); } could be simplified as setupLabel

İbrahim Özbölük · Accepted Answer · 2012-05-18 21:13:31Z

0

because label_check doesnt have this attribute :)) could u try this code ?

http://jsfiddle.net/Nzw2K/

answered May 18, 2012 at 21:13

İbrahim Özbölük

3,22225 silver badges20 bronze badges

Collectives™ on Stack Overflow

Cannot add/remove attribute onclick

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related