how to [professionally/correct way] insert php code into javascript and/or html?

Question

For instance, in javascript: 1

<script>
var name = "<?php echo 'Adam'; ?>";
alert("The name is: " + name);
</script>

or 2

<script>
alert("The name is: <?php echo 'Adam'; ?>");
</script>

And in html? 1

<head>
<?php echo '<title>Page #1</title>'; ?>
</head>

or 2

<?php $page_number = "1"; ?> // on top of the script with the rest of the other X code. //
<!doctype html....
<html>
<head>
<title>Page #<?php echo $page_number; ?></title>
</head>

I'm not looking for the short, long, easy or hard method, I'm looking for the correct method to do this.

1 - In a professional way, how this should be done?

2 - What is your way/method to do this?

Thanks

Update: Also:

<input type="button" onclick="javascript:add_friend(0,<?php echo $profile_user_id; ?>);" />

Sampson · Accepted Answer · 2012-05-20 05:43:53Z

2

There is no correct method. Rather, there are conventions that you will find yourself using, or your team will find itself using. Further, it is at times a case by case situation where your HTML may need to be processed a bit by PHP prior to being spit out, and other times it may not.

I happen to prefer seeing as clean as separation as possible, where the limits of the PHP tags are shared by the same limits of any code we would hard-wire into place.

<title><?php echo $title; ?></title>
<script>
  var strValue = <?php echo json_encode( $strValue ); ?>;
</script>

But again, that's just me.

With regards to JavaScript within HTML attributes, I would encourage you to stay as far away from that as you can. Rather than using onclick attributes, bind all of this up in your JavaScript. This, again, keeps a clean line of separation between your structure and your logic.

Which would you prefer seeing in your markup:

<input type="button" onclick="javascript:add_friend(0,288);" />

Or

<input type="button" data-action="add_friend" data-friendId="288" />

Keep your programmers out of your design, and more importantly your designers out of your code.

edited May 20, 2012 at 5:43

answered May 20, 2012 at 5:19

Sampson

269k76 gold badges546 silver badges570 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Tadeck Over a year ago

+1 I agree with your point of view. Echoing tags is completely unnecessary (and not much IDE-friendly), so this should be treated as a last resort. Also when passing PHP variables to JavaScript during page rendering, I prefer assigning their values to some JavaScript variables, or calling functions/methods that are created for that, or assigning variables to data- attributes of HTML elements, if they are somehow associated with HTML elements. But definitely not including PHP echo calls within JavaScript - one of the reasons is the problem with moving such script outside, to separate JS file.

Marc B Over a year ago

For inserting onto JS, you SHOULD use json_encode, otherwise all bets are off if the generated data is actually synatically valid JS valid or not.

Collectives™ on Stack Overflow

how to [professionally/correct way] insert php code into javascript and/or html?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related