Javascript variable scope with event handler

Question

This is the nth question about JS variable scope but I read through the rest and didn't quite get an answer.

var notification = window.webkitNotifications.createNotification(
'image.png',                      // The image.
'New Post: ',// The title.
'New stuff'// The body.
);

var itemLink = 'http://pathtothefile.com';

notification.onclick = function(itemLink) { 
window.focus(); 
window.open(itemLink,'_blank' );
this.cancel(); 
};

notification.show();

How do i get itemLink, which is defined in the global scope, to work in the onclick function?

Remove it from the parameter list. It's just in there automatically since it's a lower scope. — Corbin
– Corbin, Commented May 20, 2012 at 9:18

gdoron · Accepted Answer · 2012-05-20 09:18:25Z

2

Remove the parameter from the function:

notification.onclick = function(itemLink) { // overrides itemLink in the global
                                            // object.

Fixed code:

notification.onclick = function() { 
    window.focus(); 
    window.open(itemLink,'_blank' );
    this.cancel(); 
};

answered May 20, 2012 at 9:18

gdoron

151k59 gold badges302 silver badges376 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Joseph · Accepted Answer · 2012-05-20 09:18:43Z

1

During name conflicts, local variables take precedence. Remove or rename the argument itemLink.

notification.onclick = function(something_else) { 
    //global itemLink should be accessible
};

answered May 20, 2012 at 9:18

Joseph

120k31 gold badges186 silver badges238 bronze badges

Collectives™ on Stack Overflow

Javascript variable scope with event handler

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related