JavaScript function not returning array as expected

Question

I've got a json array and a simple function to return a bit of data. I can log the bit of data I want to the console (the function currently does this for testing), but it's not returning.

Stackers, please help my worn out brain and let me know where I've goofed.

(code is super self explanatory, function call is at the bottom of the .js)

http://jsfiddle.net/BDJeU/

function getCountryData(data, country)
{
    $.each(data, function(index) {

        if( data[index]["Country"] == country )
        {
            console.log( data[index]["Country"] );
            console.log( data[index]["data"] );
            return data[index]["data"];
        }
    });
}

brenjt · Accepted Answer · 2012-05-23 04:25:15Z

4

Try this:

http://jsfiddle.net/BDJeU/3/

    function getCountryData(data, country)
    {
        var returnData;
        $.each(data, function(index) {

            if( data[index]["Country"] == country )
            {
                returnData = data[index]["data"];
                return false;
            }
        });
        return returnData;
    }

The reason the it wasn't working was because you were returning to the each function. So setting a variable that gets assigned the value outside of the iteration will get you the data you want.

edited May 23, 2012 at 4:25

answered May 23, 2012 at 4:19

brenjt

16.3k14 gold badges80 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

brenjt Over a year ago

@Greg-J No worries. I have definitely had those moments where the answer is starring me in the face.

Matt Greer · Accepted Answer · 2012-05-23 04:20:08Z

1

Your return is inside the anonymous function used by each. So getCountryData itself has no return (so defaults to returning undefined). It needs to be something like this:

function getCountryData(data, country)
{
    var result;
    $.each(data, function(index) {

        if( data[index]["Country"] == country )
        {
            console.log( data[index]["Country"] );
            console.log( data[index]["data"] );
            result = data[index]["data"];
        }
    });

    return result;
}

answered May 23, 2012 at 4:20

Matt Greer

62.1k18 gold badges127 silver badges124 bronze badges

Comments

zerkms · Accepted Answer · 2012-05-23 04:27:07Z

1

$.grep() could be better in this case: http://jsfiddle.net/zerkms/BDJeU/12/

function getCountryData(data, country)
{
    var result = $.grep(data, function(item) {
        return item["Country"] == country;
    });

    return result && result[0] && result[0]['data'];
}

edited May 23, 2012 at 4:27

answered May 23, 2012 at 4:19

zerkms

256k73 gold badges447 silver badges551 bronze badges

1 Comment

brenjt Over a year ago

Interesting, I hadn't seen this function in jQuery before this. Good answer.

Andreas Wong · Accepted Answer · 2012-05-23 04:28:00Z

1

You need to return outside each and use return to break early out of the each iteration:

function getCountryData(data, country)
    {
        var res;
        $.each(data, function(index) {

            if( data[index]["Country"] == country )
            {
                res = data[index]["data"];

                // once found, stop searching and
                // break early out of the each iteration                  
                return; 
            }
        });
        return res;
    }

edited May 23, 2012 at 4:28

answered May 23, 2012 at 4:22

Andreas Wong

60.7k19 gold badges112 silver badges123 bronze badges

Comments

tobyodavies · Accepted Answer · 2012-05-23 04:34:44Z

1

Should you really be using each? if you are trying to filter the results to a single answer try

function getCountryData(data, country) {
    var matchingCountries = $.grep(data, function(row){
        return row.Country == country;
    });
    if (matchingCountries.length > 0)
        return matchingCountries[0].data;
}

answered May 23, 2012 at 4:34

tobyodavies

28.2k5 gold badges45 silver badges58 bronze badges

Collectives™ on Stack Overflow

JavaScript function not returning array as expected

5 Answers 5

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related