PHP combining MySQL results to one variable

Question

I'm trying to build a list of towns to add at the bottom of a site I'm working on and I can echo the variable fine within this block of PHP, however when I try to echo $result1 in another block of PHP it's only returning the first result, rather than the whole list.

Any ideas what's going on?

$result = mysql_query("SELECT town FROM jb_town_postcodes");
$results = array();
while($row = mysql_fetch_assoc($result))
echo $results1 =  $row['town'];

incorrect var inside while loop, because it overrides each time until the loop ends — Yang
– Yang, Commented May 23, 2012 at 8:02

iiro · Accepted Answer · 2012-05-23 09:40:53Z

3

while($row = mysql_fetch_assoc($result))
$results[]= $row['town'];

print_r($results);

Now

for example

echo $results[0] will print the first value e.g. Wolverhampton echo $results[2] will print Cannock

echo $results[count($results)-1] will print the last value

edited May 23, 2012 at 9:40

answered May 23, 2012 at 7:59

iiro

3,1381 gold badge22 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

franglais Over a year ago

You've answered it so quickly that Stack Overflow won't actually let me accept your answer yet :D Thanks!

franglais Over a year ago

how do I get it to show it not as an array, but a list of values? so rather than "Array ( [0] => Wolverhampton [1] => Tipton [2] => Cannock [3]" have "Wolverhampton Tipton Cannock"

iiro Over a year ago

for example echo $results[0] will print Wolverhampton and echo $results[2] will print Cannock

koral · Accepted Answer · 2012-05-23 08:02:24Z

0

Each iteration you save in you $result1 a new value from $result - that's why after loop you have only last town.

answered May 23, 2012 at 8:02

koral

2,9873 gold badges44 silver badges71 bronze badges

Comments

Vishal · Accepted Answer · 2012-05-23 08:04:33Z

0

Try this:

$result = mysql_query("SELECT town FROM jb_town_postcodes");
$results = array();

while($row = mysql_fetch_assoc($result))
  // at every iteration, store value of 
  // $row['town'] to new index of $results1
  $results1[] =  $row['town'];

// now use $results anywhere

answered May 23, 2012 at 8:04

Vishal

2,18114 silver badges25 bronze badges

Comments

David · Accepted Answer · 2012-05-23 08:14:50Z

0

You should use curly brackets ;)

while($row = mysql_fetch_assoc($result))
{
  $results[]= $row['town']; 
}

answered May 23, 2012 at 8:14

David

4,11911 gold badges52 silver badges105 bronze badges

2 Comments

peipst9lker Over a year ago

If you only put 1 command inside then you should not use them to make it more readable!

David Over a year ago

@peipst9lker maybe but if you have very much lines it's better

Collectives™ on Stack Overflow

PHP combining MySQL results to one variable

4 Answers 4

3 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related