Should I use const string for SQL with parameters (.NET C#)?

Question

I'm wondering if I should use const string when using code like this:

    public DataTable GetSomeData(int id)
    {
        var con = new SqlConnection(ConnString);
        const string sql = "SELECT * FROM [data] WHERE [id]=@id";
        var cmd = new SqlCommand(sql, con);
        cmd.Parameters.AddWithValue("@id", id);

        var dt = new DataTable();
        con.Open();
        SqlDataReader dr = cmd.ExecuteReader();
        dt.Load(dr);
        con.Close();

        return dt;
    }

ReSharper suggested I solved it this way, but I'm told I shouldn't because it's not really constant. It changes when the parameters are added. I thought this way was proper because it's constant on the server running the code and only changes when it reaches the database.

So, what is the best way to do this?

"It changes when the parameters are added" - what does? sql doesn't... — AakashM
– AakashM, Commented May 24, 2012 at 16:21

aleroot · Accepted Answer · 2012-05-24 14:57:06Z

7

The string with the placeholders of parameters should be constant and it is right to declare it as a constant, it is the command object that is mutable, but the query string is constant and immutable .

answered May 24, 2012 at 14:57

aleroot

73k32 gold badges182 silver badges220 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Should I use const string for SQL with parameters (.NET C#)?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related