c# static class declaration

Question

Hi the intent of the code below is to return a static class which holds a related set of data. Can you recommend how I can do this better?

public class People
{
    //want info to be setup in this class, so it can be accessed elsewhere
    public static readonly string[] ab = { "ALBERT", "EINSTEIN"};       
    public static readonly string[] dk = { "DONALD", "KNUTH" };

   //is this efficient or instantiated once per access? IF SO HOW CAN I DO THIS BETTER? 
    public static readonly Info AB = new Info(ab, 100); 
    public static readonly Info DK = new Info(dk, 80);

}

public class Info
{
    private string[] _name;
    private int _age;

    public string[] Name { get{ return _name}; }
    public int Age { get { return _age; } }

    public Info(string[] n, int a)
    {
        _name = n;
        _age = a;
    }
}

fyi, the values Name are mutable.

Daniel A. White
– Daniel A. White

2012-05-26 00:05:34 +00:00
Commented May 26, 2012 at 0:05 — Daniel A. White
– Daniel A. White, Commented May 26, 2012 at 0:05

Chopin · Accepted Answer · 2012-05-30 20:26:18Z

3

is this efficient or instantiated once per access?

If you mean the moment at when the instances of Info are constructed, they are built before the first access to the member. So no matters how many times you call People.AB, the object will be the same.

From MSDN about Static Classes and Static Class Members:

Static members are initialized before the static member is accessed for the first time and before the static constructor, if there is one, is called.

If you want to make your instances of Info totally immutable (as Daniel says, the values of _name could be changed once you get a reference to the array), you can change the type of _name and its property accesor to:

private List<string> _name;

public IList<string> Name { get { return _name.AsReadOnly(); } }

Hope I've understood your needs!

edited May 30, 2012 at 20:26

answered May 26, 2012 at 0:32

Chopin

1,45217 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

River Over a year ago

why did you choose to use IList<string> in your getter? since the private variable _name is already using a concrete List<string> type?

Chopin Over a year ago

That's because the AsReadOnly() method returns a ReadOnlyCollection<T> instance, whichs implements the IList<T> interface, but doesn't extends the List<T> class, so it couldn't be converted.

Collectives™ on Stack Overflow

c# static class declaration

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related