Correctly removing objects from view and array?

Question

In my "connect4" style game I have an array representing a 7x6 grid, each "cell" in the array contains either NSNull or a UIView subclass 'CoinView'. Is the following the correct way to remove objects from the NSMutableArray and the primary view?

- (IBAction)debugOrigin:(id)sender {
    int x = 0;
    int y = 0;
    //get the coin object form the grid
    CoinView *coin = [[grid objectAtIndex:x] objectAtIndex:y];

    //cancel if there's no coin there
    if ([coin isKindOfClass:[NSNull class]]) { return; }

    //remove the coin from memory
    [coin removeFromSuperview];
    coin = nil;
    [[grid objectAtIndex:x] setObject:[NSNull null] atIndex:y]; //will this leak?

}

Thanks!

If you are using ARC, this should be fine. Using [array setObject:atIndex] removes any previous objects from the array, which automatically releases it behind the scenes. If the CoinView is being held onto anywhere else, it will still exist - but by that very nature, it isn't a leak because something would still be referencing it — CrimsonDiego
– CrimsonDiego, Commented May 27, 2012 at 6:17

clearscreen · Accepted Answer · 2012-05-27 06:55:56Z

3

Your code will not leak, and is in fact (almost) correct.

You should remove this comment, as you're not dealing with memory in your code (and it may end up confusing you as to what the code really does):

//remove the coin from memory

In the following line you're removing the view referenced by local variable "coin" from its superview:

[coin removeFromSuperview];

And you assign nil to your local variable coin, which is good practice to make sure it's not being used later in the code:

coin = nil;

As far as I know there is no setObject:AtIndex: for NSMutableArray. Use replaceObjectAtIndex:withObject: instead:

[[grid objectAtIndex:x] replaceObjectAtIndex:y withObject:[NSNull null]]; //will this leak?

As a last note, I recommend that you read up a bit on memory management and memory leaks (from Apple's developers documentation). The first offers you some hints and tips that make memory management much easier to understand.

edited May 27, 2012 at 6:55

answered May 27, 2012 at 6:32

clearscreen

2,03719 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Greg Over a year ago

When placing code within text, delimit it with backticks (`), not asterisks. That way, it will be monospaced and easier to read, not italic.

Collectives™ on Stack Overflow

Correctly removing objects from view and array?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related