Javascript replace error

Question

I have one problem with function in Javascript. When I insert text in textarea, function sends text to PHP script with AJAX, but I have problem when I insert two or three words, e.g Bosnia and Herzegovina then the script does not work. I used string replace :

    function provjeraDrzave(rijec) {
        rijec = rijec.replace(" ", "%20");
        $.ajax({
            type: "GET",
            url: "/drzava.php?slovo=" + randomslovo + "&drzava=" + rijec,
            success: function (odgovor) {
                $('#rezultati').replaceWith($("<span id='rezultati'>" + odgovor + "</span>"));
            },
            error: function () {
                alert('Doslo je do pogreske');
            }
        });
    }

It should work as follows: When I insert Bosnia and Herzegovina that must change to Bosnia%20and%20Herzegovina but that change to Bosnia%20and Herzegovina and that does not work. Where is the problem ??

Pierre · Accepted Answer · 2012-05-27 20:29:12Z

2

Why don't you use, for example, the native encodeURIComponent function, which is made for this?

Or, even better, let jQuery take care of URL encoding for you, using the data config param:

function provjeraDrzave(rijec) {
    $.ajax({
        type: "GET",
        data: {
            slovo: randomslovo,
            drzava: rijec
        },
        url: "/drzava.php",
        success: function (odgovor) {
            $('#rezultati').replaceWith($("<span id='rezultati'>" + odgovor + "</span>"));
        },
        error: function () {
            alert('Doslo je do pogreske');
        }
     });
}

edited May 27, 2012 at 20:29

answered May 27, 2012 at 20:21

Pierre

6,1725 gold badges34 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Joseph · Accepted Answer · 2012-05-27 20:22:31Z

2

jQuery $.ajax can receive url arguments via the data property and should automatically serialize it for you.

data

Data to be sent to the server. It is converted to a query string, if not already a string. It's appended to the url for GET-requests... Object must be Key/Value pairs...

$.ajax({
    type: 'GET',
    url: '/drzava.php'
    data : {
        'slovo' : randomslovo,
        'drzava' : rijec          //no need  to replace
    }
    success: function (returndata) {...},
    error: function () {...}
});

answered May 27, 2012 at 20:22

Joseph

120k31 gold badges186 silver badges238 bronze badges

Comments

fanf · Accepted Answer · 2012-05-27 20:25:23Z

0

If you absolutely want to do this way try

rijec = rijec.replace(/\ /g, "%20");

but encodeURIComponent would be more appropriate.

answered May 27, 2012 at 20:25

fanf

1201 silver badge7 bronze badges

Collectives™ on Stack Overflow

Javascript replace error

3 Answers 3

Comments

data

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

data

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related