Java: code duplication in classes and their Junit test cases

Question

I've been writing code that processes certain fields of an object by modifying their values. To test it, I first wrote a JUnit test case that recursively traverses fields of an object and makes sure they're correctly modified. The CUT (Class Under Test) does something vary similar: it recursively traverses fields of an object and modifies them as required.

So the code to recursively traverse the fields remains the same in test case and CUT, and is currently duplicated, which is against DRY. So I have two questions:

1) have you come across such situations in your project? If yes, did you apply DRY, or let such duplication remain as is?

2) if I put this common code in a util method, I will need to write a test case to test that, which would again involve traversing fields recursively. So how can this be solved without adding any duplication?

Tomasz Nurkiewicz · Accepted Answer · 2012-05-28 07:50:45Z

4

You have just hit the ugly mirror testing anti-pattern. If your CUT has a bug, most likely you will copy it to your test case, essentially verifying that a bug is still there.

You must show us some more code, but basically your test case should be much simpler, no for loops, no conditions - just assertions. If your production code does some fancy traversing, reflection, etc. on complicated data structures - create a test Java object and test every field manually in the unit test.

answered May 28, 2012 at 7:50

Tomasz Nurkiewicz

342k72 gold badges713 silver badges680 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

shrini1000 Over a year ago

I've shown similar code here: stackoverflow.com/questions/10749946/… The objects I'm processing are large, so writing a non-recursive JUnit to test them will become quite long. Maybe that's the only way to test it. And you're right about having the same bug in test and CUT. I burnt my fingers with it in this same code.

Tomasz Nurkiewicz Over a year ago

@shrini1000: looking at your code: yes, create some sample object and do all the assertions manually. This is the right way.

JohnB · Accepted Answer · 2012-05-28 08:03:38Z

1

Use the visitor pattern to abstract traversing the tree, and then build visitors both in the Test case and in your productive code. And test the Visitor infrastructure separately.

edited May 28, 2012 at 8:03

answered May 28, 2012 at 7:49

JohnB

13.8k6 gold badges42 silver badges67 bronze badges

Collectives™ on Stack Overflow

Java: code duplication in classes and their Junit test cases

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related