PHP Array Removing Matching Values

Question

I built this function in PHP so far called removeAllValuesMatching, but I cannot seem to get it working. I am passing in two parameters $arr and $value. Not sure why this is happening. Any help would be greatly appreciated. This is what I have so far:

<?php 
$arr = array(
   'a' => "one",
   'b' => "two",
   'c' => "three",
   'd' => "two",
   'e' => "four",
   'f' => "five",
   'g' => "three",
   'h' => "two"
);
function removeAllValuesMatching($arr, $value){
 foreach ($arr as $key => $value){
 if ($arr[$key] == $value){
 unset($arr[$key]);
 }
 }
 return $arr = array_values($arr);
 }

print_r(removeAllValuesMatching($arr, "two"));

?>

What isn't working? "I am passing in two parameters $arr and $value. Not sure why this is happening." - are you missing something between these two sentences? — Evan Mulawski
– Evan Mulawski, Commented May 30, 2012 at 18:04
When I pass in the parameter of ($arr, "two"), It prints out none of the elements of the array. It should print out to the screen one, three, four, five, three — vpd05141989
– vpd05141989, Commented May 30, 2012 at 18:04

Niko · Accepted Answer · 2012-05-30 18:05:45Z

3

You're overwriting $value here:

foreach ($arr as $key => $value){

Simply rename it:

foreach ($arr as $key => $val) {
    if ($val == $value) {

However, a better way to delete elements from an array is this:

function removeAllValuesMatching(array $arr, $value) {
    $keys = array_keys($arr, $value);
    foreach ($keys as $key) {
        unset($arr[$key]);
    }
    return $arr;
}

answered May 30, 2012 at 18:05

Niko

26.8k9 gold badges97 silver badges112 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gilles Quénot · Accepted Answer · 2012-05-30 18:09:42Z

0

This is my full version, with no variables collision and indenting : that's not an option, you should always indent correctly

<?php 
$arr = array(
    'a' => "one",
    'b' => "two",
    'c' => "three",
    'd' => "two",
    'e' => "four",
    'f' => "five",
    'g' => "three",
    'h' => "two"
);

function removeAllValuesMatching($arr, $arg){
    foreach ($arr as $key => $value){
        if ($arr[$key] == $arg){
            unset($arr[$key]);
        }
    }
    return $arr = array_values($arr);
}

print_r(removeAllValuesMatching($arr, "two"));

?>

answered May 30, 2012 at 18:09

Gilles Quénot

188k43 gold badges232 silver badges229 bronze badges

Comments

SamGoody · Accepted Answer · 2022-07-26 08:57:26Z

0

Not a fix for your method, but array_diff will acheive the same result, while also allowing you to remove multiple values.

$arr = [
   'a' => "one",
   'b' => "two",
   'c' => "two",
   'd' => "three",
];  
$filtered = array_diff($arr, ['one', 'two']);
print_r($filtered); // Array([d] => three)

edited Jul 26, 2022 at 8:57

answered Jul 26, 2022 at 8:48

SamGoody

14.7k10 gold badges84 silver badges93 bronze badges

1 Comment

SamGoody Over a year ago

And, of course, you could update the original array without an intermediary array: $arr = array_diff($arr, ['one', 'two']);

Collectives™ on Stack Overflow

PHP Array Removing Matching Values

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related