Knockout.js: adding elements to observable-array

Question

I have a problem with loading an element into my items Observable-Array - with an event.

ViewModel = (function () {
    var 
        items = ko.observableArray([]),

        removeItems = function (element) {
            items.remove(element);
        },
        saveAll = function () {
            return ko.toJS(items);
        },
        addItem = function (element) {
            items.push(element);
            return false;  // no Page-Reload after button-klick
        };

    return {
        Items: items,
        // i call addItem with a dummy object (for testing)
        clickSave: addItem(new Customer(1, "Tfsd", "Tfsd"))
    };
})();

(fiddle)

Why is the addItem function called, without even clicking the button? is it because of the () at the end of the function?

    addItem = function (element) {
        items.push(element);
        return false;  // no Page-Reload after button-click
    };

what can i do to make this for the event only? Or is my problem somewhere else?

napoleonss · Accepted Answer · 2012-06-06 11:10:34Z

3

Use

return {
    Items: items,
    clickSave: addItem
};

answered Jun 6, 2012 at 11:10

napoleonss

1,14914 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tomalak · Accepted Answer · 2012-06-04 13:47:48Z

0

Why is the addItem function called, without even clicking the button? is it because of the () at the end of the function?

Yes.

Do this instead:

return {
    Items: items,
    clickSave: function() {
        addItem(
            new Customer( 
                items().length + 1, // or whatever you use to determine new IDs
                $("#inputVorname").val(),
                $("#inputNachname").val()
            )
        );
    }
};

answered Jun 4, 2012 at 13:47

Tomalak

339k68 gold badges547 silver badges635 bronze badges

Comments

jwize · Accepted Answer · 2013-07-02 20:58:55Z

0

This should work if you want the new item to be created always the same.

return {
    Items: items,
    clickSave: addItem.bind(null, new Customer(1, "Tfsd", "Tfsd"))
};

answered Jul 2, 2013 at 20:58

jwize

4,1951 gold badge36 silver badges61 bronze badges

Collectives™ on Stack Overflow

Knockout.js: adding elements to observable-array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related