Simple javascript function not working in IE7

Question

Code works across all major browsers, but firing a simple alert on click is not working.

This is in my header

<script type="text/javascript">
    function this_function() {
        alert("got here mango!");
    }
</script>

This is in the body

<button type="button" onclick="this_function()">click me</button>

If I put the "onclick" into the tag then it works fine and dandy.

Any and all suggestions on how to get this to work in IE would be great. Thanks in advance.

Sorry, by "into the tag" i meant putting onclick="alert()" into the tag.

I'm confused with the 'If I put the "onclick" into the tag then it works fine'. The source that you show us have the onclick. Are you trying with another way? Can you provide a jsfiddle with your error? — user800014
– user800014, Commented Jun 4, 2012 at 21:13

Jivings · Accepted Answer · 2012-06-04 21:18:44Z

1

~~Try: <button type="button" onclick="javascript:this_function();">click me</button>~~

It's advised to separate JavaScript and markup. Thus regardless you should assign an ID to the button and attach the onclick handler like this:

document.getElementById("button").onclick = function() {
     alert("got here mango!");
};

edited Jun 4, 2012 at 21:18

answered Jun 4, 2012 at 21:10

Jivings

23.3k7 gold badges63 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Matt Fikowski Over a year ago

Thanks for the response. I tried what you suggested, but it did not work. :/

Bergi Over a year ago

@Jivings: He has his script in <head>, so he will need a DOMready handler before setting onclick properties.

John Culviner · Accepted Answer · 2012-06-04 21:28:26Z

0

Are you running this sandboxed? If you aren't I would highly suggest trying this all by its self in a single HTML file with no other things going on. It is possible that IE7 is blowing up (quietly) on another script issue that is preventing your "this_function" from loading into the DOM properly.

After you have done this put the in your there is no need for it to be in the head and I have actually seen this cause problems under certain conditions

answered Jun 4, 2012 at 21:28

John Culviner

23.1k6 gold badges59 silver badges53 bronze badges

Collectives™ on Stack Overflow

Simple javascript function not working in IE7

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related