php assign new value to variable if condition is met

Question

What is a better way in the code below to add a new value to the variables $timestop and $time_diff if the condition is met?

//Calculates difference in time using 24h format

$timestart = strtotime("14:00:00");
$timestop = strtotime("07:00:00"); //if smaller value, it must end next day and meets the condition below

$time_diff = $timestop - $timestart; //elapsed time

if ($time_diff < 0 || $time_diff == 0) //if result is negative value, $timestop ends next day
{
   $timestop = strtotime( '+1 day' , strtotime("07:00:00") ); //+ 1 day changes timestamp
}

/* UPDATED */

$time_diff = $timestop - $timestart; //added again

echo $time_diff;

If the variable didn't update, the condition in the if statement was not met. — Evan Mulawski
– Evan Mulawski, Commented Jun 17, 2012 at 0:11
Okay, so if you add one day, the time is the same. Any time + 24 hrs is the same time. — Evan Mulawski
– Evan Mulawski, Commented Jun 17, 2012 at 0:12
before the if: 1339909200, after the if: 1339995600. of course it does update. — dan-lee
– dan-lee, Commented Jun 17, 2012 at 0:13
Why don't you use if ($time_diff <= 0) instead of if ($time_diff < 0 || $time_diff == 0) ? — Cranio
– Cranio, Commented Jun 17, 2012 at 0:21

dan-lee · Accepted Answer · 2012-06-17 01:39:08Z

1

No, overwriting variables is no problem, and it's daily routine. You are not even overwriting in any other type, you're just resetting to another integer value.

It's even better, because you don't waste any extra memory space (which of course is not high, but think of it in a big scale).

edited Jun 17, 2012 at 1:39

answered Jun 17, 2012 at 1:18

dan-lee

14.5k6 gold badges55 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

php assign new value to variable if condition is met

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related