javascript recursive function wrong answer

Question

function test(i)
{
  if(i==2)
      return {title:"finished at 2", data:"empty"}
  else
  {
          a=[]
          a.push(test(i+1))
          a.push(test(i+1))
          return {title:"number "+i, data:a}
    }
}

alert(JSON.stringify(test(0)))

Here, test(0) should be

{
    title: "number 0",
    data: [{
        title: "number 1",
        data: [{
            title: "finished at 2",
            data: "Empty"
        }, {
            title: "finished at 2",
            data: "Empty"
        }]
    }, {
        title: "number 1",
        data: [{
            title: "finished at 2",
            data: "Empty"
        }, {
            title: "finished at 2",
            data: "Empty"
        }]
    }]

while you can see it is different in the code's result. How and Why? What do I do to make it right?

You might consider using console.log() in the future instead of alert(). Not an answer though. — PeeHaa
– PeeHaa, Commented Jun 25, 2012 at 11:30
@Furqan oops!! sorry, forgot to update the fiddle and the link. — prongs
– prongs, Commented Jun 25, 2012 at 11:30

Guffa · Accepted Answer · 2012-06-25 11:33:25Z

4

You are using a global variable in your recursive function, so it will be changed while you are using it.

Change this:

a = []

to:

var a = []

answered Jun 25, 2012 at 11:33

Guffa

703k111 gold badges760 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

javascript recursive function wrong answer

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related