Shortest way to code this php multiple if condition

Question

I am trying to do a query like:

If $_GET['page'] == 'items' AND $_GET['action'] == 'new' OR 'edit'

Here's what I have:

if (isset($_GET['page']) && $_GET['page'] == 'items') {
    if (isset($_GET['action']) && $_GET['action'] == 'new' || isset($_GET['action']) && $_GET['action'] == 'edit') {

        // This is what Im looking for

    }
}

Is this correct, and is this the easiest way to make this query?

Yes, and any other developer will understand what your doing because your names are on point. — Jonathan Römer
– Jonathan Römer, Commented Jun 25, 2012 at 14:03
When you have more "OR" statements you could do it with a switch inside the first if statement. — René Höhle
– René Höhle, Commented Jun 25, 2012 at 14:03
@OP you already had the right solution in your own wording :) Your second line just needed brackets () at the right places and you could have pasted it straight into your code as for php OR and AND are synonyms for || and && ;) — Havelock
– Havelock, Commented Jun 25, 2012 at 14:17

Mark Nemec · Accepted Answer · 2012-06-25 14:02:56Z

3

You could have done it like this as well:

if (isset($_GET['page']) && $_GET['page'] == 'items') {
    if (isset($_GET['action']) && ($_GET['action'] == 'new' || $_GET['action'] == 'edit')) {

    }
}

answered Jun 25, 2012 at 14:02

Mark Nemec

1191 gold badge2 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

feeela Over a year ago

This does not check for the page…

Mark Nemec Over a year ago

I meant it for the second if of course :) (I edited it, so it's more clear.)

Havelock Over a year ago

+1 Correct A && B || A && C equals A && (B || C). BTW the OP already had it in words :)

Jon Taylor Over a year ago

Id still suggest checking that both page and action are set before bothering to check what their values are. As I said in my answer there is no point in checking the value of page if you then find out that action is not set.

feeela Over a year ago

@Jon Taylor Well, you could have a default action if none is given but a page is selected: Magento for example uses an action named "index" of none was given.

|

Jon Taylor · Accepted Answer · 2012-06-25 14:05:58Z

2

Your way is perfectly fine, although I would almost be tempted to do it the following way. The only reason I suggest this is that your code requires that both action and page are set. If action is not set then there isn't much point checking if the page is == 'items'.

if(isset($_GET['page']) && isset($_GET['action'])) {
    if($_GET['page'] == 'items' && ($_GET['action'] == 'new' || $_GET['action'] == 'edit')) {
        //do code here
     }
}

answered Jun 25, 2012 at 14:05

Jon Taylor

7,9255 gold badges32 silver badges55 bronze badges

2 Comments

Lionel Chan Over a year ago

You can do isset($_GET['page'], $_GET['action']) in one shot as well ;)

Jon Taylor Over a year ago

Ah you learn something new everyday, I did not realise this. Thanks.

feeela · Accepted Answer · 2012-06-25 14:04:17Z

1

You may also try in_array like:

if (isset($_GET['page']) && $_GET['page'] == 'items')
{
    if ( !empty( $_GET['action'] ) && in_array( $_GET['action'], array( 'new', 'edit' ) )
    {
        // This is what Im looking for
    }
}

answered Jun 25, 2012 at 14:04

feeela

30k7 gold badges61 silver badges73 bronze badges

Comments

Ziumin · Accepted Answer · 2012-06-25 14:08:33Z

0

That is one of possible solutions

if ( @$_GET['page'] == 'items' && in_array(@$_GET['action'], array('new','edit')))

answered Jun 25, 2012 at 14:08

Ziumin

4,8701 gold badge29 silver badges34 bronze badges

2 Comments

Jon Taylor Over a year ago

Im not sure I would encourage this, although it will work it could produce errors later on. @ just supresses errors and so rather than error handling you are just ignoring (which in my experience is bad).

Ziumin Over a year ago

I used it just to shorten the code. And yes, using @ is not a good practice.

Uladzimir Pasvistselik · Accepted Answer · 2012-06-25 14:21:32Z

0

Everything is ok, but also you can use function:

function paramIs($param, $values) {
    $result = false;
    foreach ((array)$values as $value) {
        $result = $result || isset($_GET[$param]) && $_GET[$param] == $value;
    }
    return $result;
}

Usage:

if (paramIs('page', 'items') && paramIs('action', array('new', 'edit')))
{
    // your code here
}

It will reduce the number of repetitions in your code and encapsulate logic in one place

answered Jun 25, 2012 at 14:21

Uladzimir Pasvistselik

3,92127 silver badges30 bronze badges

Collectives™ on Stack Overflow

Shortest way to code this php multiple if condition

5 Answers 5

6 Comments

2 Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

6 Comments

2 Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related