Uncaught Reference Error with inline javascript

Question

I have the following function:

if ($(this).find('#sel').length == 0) {
    var before = $(this).text();
    var title_id = $(this).parent().attr('id');
    $(this).html("<select id='sel' onchange='selectdone(this, title_id=title_id)>
                   ...</select>");
}

From this I get Uncaught ReferenceError: title_id is not defined. Why isn't the onchange function inside on line 4 not picking up on the variable that I've defined previously? How would I rewrite the above correctly?

Niet the Dark Absol · Accepted Answer · 2012-06-26 22:51:07Z

2

Did you mean this?

$(this).html("<select id='sel' onchange='selectdone(this, "+title_id+");'>...</select>");

answered Jun 26, 2012 at 22:51

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David542 · Accepted Answer · 2012-06-26 22:51:37Z

0

Use string concatenation here:

$(this).html("<select id='sel' onchange='selectdone(this, title_id=" + title_id +");'>...

answered Jun 26, 2012 at 22:51

David542

112k211 gold badges581 silver badges1.1k bronze badges

Comments

Pointy · Accepted Answer · 2012-06-26 22:51:48Z

0

It's happening because you're defining the "change" handler as part of a string, so the language has no idea that there's code in there.

Try this:

$(this).html($("<select/>", {
  id: 'sel',
  change: function() { selectdone(this, title_id) }
}));

Since you're using jQuery anyway, you should get in the habit of managing your event handlers via the library instead of with "onfoo" attributes.

answered Jun 26, 2012 at 22:51

Pointy

415k62 gold badges600 silver badges631 bronze badges

Collectives™ on Stack Overflow

Uncaught Reference Error with inline javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related