PHP inside HTML inside PHP [duplicate]

Question

I can't make the following work. I know it's because of the PHP function inside the string of HTML, but I don't know how to fix it.

echo '<aside class="tipContainer">'.'<div>'.'<h1>'.$header.'</h1>'.'<img src="<?php bloginfo('template_url'); ?>/images/pencil_Tip.gif" alt="">'.'</div>'.'<p>'.$content.'</p>'.'</aside>';

I receive this error: unexpected T_STRING, expecting ',' or ';' in ....

echo '<aside class="tipContainer">'.'<div>'.'<h1>'.$header.'</h1>'.'<img src="'.bloginfo('template_url').'/images/pencil_Tip.gif" alt="">'.'</div>'.'<p>'.$content.'</p>'.'</aside>'; — user1190992
– user1190992, Commented Jun 27, 2012 at 17:09
You don't need to concatenate html tags with. (e.g: ) '<div>'.'<h1>' could be changed to '<div><h1>'. — AKS
– AKS, Commented Jun 27, 2012 at 17:12

Thomas · Accepted Answer · 2012-06-27 18:49:45Z

11

Try:

echo '<aside class="tipContainer"><div><h1>' . $header . '</h1>'.
     '<img src="' . get_bloginfo('template_url') . '/images/pencil_Tip.gif" ' .
     'alt=""></div><p>' . $content . '</p></aside>';

Since you are already inside <?php ?> tags for your echo statement, you don't need them when you want to call get_bloginfo(). Just call the function as part of the string concatenation.

edited Jun 27, 2012 at 18:49

Thomas

2,1371 gold badge32 silver badges47 bronze badges

answered Jun 27, 2012 at 17:09

drew010

70.3k11 gold badges144 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Thomas Over a year ago

thats just ugly. look at Marvos answer.

Thomas Over a year ago

I edited it and it's under review :-)

Thomas Over a year ago

I'll upvote if you remove the unneeded concatenations.

drew010 Over a year ago

@Thomas I voted to approve the edit, 1 more needed. Also cleaned up my answer. thanks.

Nick · Accepted Answer · 2012-06-27 18:14:51Z

5

PHP is nested too deep. (php nested in php). Try this:

echo '<aside class="tipContainer"><div><h1>'.$header.'</h1><img src="'.bloginfo("template_url").'/images/pencil_Tip.gif" alt=""></div><p>'.$content.'</p></aside>';

edited Jun 27, 2012 at 18:14

Nick

6,3462 gold badges32 silver badges48 bronze badges

answered Jun 27, 2012 at 17:09

William

3,52929 silver badges35 bronze badges

6 Comments

j08691 Over a year ago

You can remove the concatenation being done here '.'<div>'.'

Mark Bubel Over a year ago

Ok, thanks this did return the URL I need but it did not place it inside the img element's src attr. The URL now appears as a string outside the aside element.

William Over a year ago

good call @j08691 . It was some rather deeply nested code, and I had to make sure not to use single quotes when they meant to output strings when it was within another string (it's like inception :) ) and I overlooked this.

William Over a year ago

@MarkBubel this is because WordPress getbloginfo echo's the output. Use get_bloginfo() instead.

Mark Bubel Over a year ago

Aha... thanks, William! It now works as expected.

|

Thomas · Accepted Answer · 2012-06-27 17:47:21Z

4

Try:

//stop executing PHP, go to plain HTML
 ?>
<aside class="tipContainer">
<div>  
    <h1><?php echo $header?> </h1>
    <img src="<?php bloginfo('template_url'); ?>/images/pencil_Tip.gif" alt="">
</div>
<p>
<?php echo $content ?>
</p>
</aside>

<?php //start php again

often makes for cleaner, easier to maintain code to interweave php into html, rather than the other way aroudn

edited Jun 27, 2012 at 17:47

Thomas

2,1371 gold badge32 silver badges47 bronze badges

answered Jun 27, 2012 at 17:10

EricR

1,4973 gold badges21 silver badges42 bronze badges

Comments

Marvo · Accepted Answer · 2012-06-27 22:08:03Z

2

Try this:

echo '<aside class="tipContainer"><div><h1>' . $header . '</h1><img src="'
. bloginfo('template_url')
. '/images/pencil_Tip.gif" alt=""></div><p>' . $content . '</p></aside>';

edited Jun 27, 2012 at 22:08

answered Jun 27, 2012 at 17:09

Marvo

18.2k8 gold badges53 silver badges75 bronze badges

6 Comments

Thomas Over a year ago

+1 removed unneeded concatenation

Marvo Over a year ago

Okay, cool. But why did you ADD unnecessary concatenation by pulling $header and $content out of the string? You don't need to do that for simple variables like that in PHP.

Thomas Over a year ago

That doesn't work. Variables inside single quotes are not interpreted

Marvo Over a year ago

Yep, you're right. I must use double quotes instinctively, and my test of this had double quotes. Learn something new daily.

Thomas Over a year ago

Also note that there were much discussions on what is faster, single or double quotes. But today it doesn't really matter. There are operations (database, regular expressions, ...) which need a magnitude more time.

|

Joel · Accepted Answer · 2012-06-27 17:09:28Z

0

echo '<aside class="tipContainer">'.'<div>'.'<h1>'.$header.'</h1>'.'<img src="' . bloginfo('template_url') . '/images/pencil_Tip.gif" alt="">'.'</div>'.'<p>'.$content.'</p>'.'</aside>';

answered Jun 27, 2012 at 17:09

Joel

1,1401 gold badge11 silver badges16 bronze badges

Comments

biziclop · Accepted Answer · 2012-06-27 17:09:49Z

0

Explanation why it not works:

'<img src="<?php bloginfo('template_url'); ?>/images ...
'______ php string _______'            '__ another php string ...
                           ^^^^^^^^^^^^
                           this is not part of the sting,
                           because you just closed it.

Solutions:

'aaa' . "'bbb'" . 'ccc' : alternate quoting style
'aaa\'bbb\'ccc' : quote the single-quote in the string
"aaa'bbb'ccc" : use double quotes to quote a string containing single quotes

answered Jun 27, 2012 at 17:09

biziclop

14.6k3 gold badges52 silver badges66 bronze badges

Comments

Jocelyn · Accepted Answer · 2012-06-27 17:10:22Z

0

echo '<aside class="tipContainer"><div><h1>'.$header.'</h1><img src="' . bloginfo('template_url') . '/images/pencil_Tip.gif" alt=""></div><p>'.$content.'</p></aside>';

answered Jun 27, 2012 at 17:10

Jocelyn

11.4k11 gold badges47 silver badges63 bronze badges

Comments

Eswar Rajesh Pinapala · Accepted Answer · 2012-06-27 17:11:32Z

0

try the below,

--> Avoid as much concatenation as possible, no need to split/concatenate strings often, ex : "string1" . "string2" is not required, simply do "string1string2" to avoid confusion.

--> Use an IDE, It helps a lot to debug syntax errors.

<?php
echo '<aside class="tipContainer"><div><h1>'. $header. '</h1><img src="' . bloginfo('template_url') . '"/images/pencil_Tip.gif" alt=""></div><p>'.$content.'</p></aside>';
?>

answered Jun 27, 2012 at 17:11

Eswar Rajesh Pinapala

4,9314 gold badges35 silver badges40 bronze badges

Collectives™ on Stack Overflow

PHP inside HTML inside PHP [duplicate]

8 Answers 8

4 Comments

6 Comments

Comments

6 Comments

Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

4 Comments

6 Comments

Comments

6 Comments

Comments

Comments

Comments

Comments

Linked

Related