java.util.ConcurrentModificationException Occurrs during List.add()

Question

I get a weird problem. Getting java.util.ConcurrentModificationException. But I'm not modifying the current collection. Please help.

Method Call

setAllAddress((List<AddressBean>) usrProfileResp.getAddressBeanList());
setShippingAddresses(getAllAddress());

Methods

public List<AddressBean> getAllAddress() {
    return allAddress;
}

public void setShippingAddresses(List<AddressTokenBean> shippingAddresses) {
        shippingAddresses = new ArrayList<AddressBean>();
        List<AddressBean> addresses = getAllAddress();
        if (addresses != null && addresses.size() > 0) { 
            for (AddressBean addr : addresses) { // EXCEPTION OCCURS HERE
                if (!Constants.BILLING_ADDRESS.equals(addr.getAddressType())) {                    
                    shippingAddresses.add(addr);                
                }
            }
        }
}

Is shippingAddresses the same instance as addresses? Post getAllAddresses() and any more relevant code. — cklab
– cklab, Commented Jun 28, 2012 at 7:05
I have added the shipping address init in code. Please check. — Vaandu
– Vaandu, Commented Jun 28, 2012 at 7:06
And getAllAddress()? It's starting to look like shippingAddresses is a class variable and getAllAddress() returns it. — cklab
– cklab, Commented Jun 28, 2012 at 7:07
There must be another thread modifying the collection returned by getAllAddress(). — hmjd
– hmjd, Commented Jun 28, 2012 at 7:10

Peter Lawrey · Accepted Answer · 2012-06-28 07:12:24Z

1

The most likely explaination is that addresses and shippingAddresses refer to the same collection. You can check this in your debugger.

Does getAllAddresses() use shippingAddresses at all?

Are you sure this collection is not being modifed in another thread? Does this happen all the time or only occasionally?

edited Jun 28, 2012 at 7:12

answered Jun 28, 2012 at 7:05

Peter Lawrey

535k83 gold badges770 silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Vaandu Over a year ago

Thanks for your response. But I do initialize shippingAddresses. :(

Peter Lawrey Over a year ago

Not sure what that means, but I assume you are absolutely sure they are not the same object and you have checked in your debugger?

Ahmad Over a year ago

@Peter..Its obvious..he is creating a new Collection

Peter Lawrey Over a year ago

Without the source for getAllAdresses() it not obvious.

Peter Lawrey Over a year ago

@Ahmad obviously there is no bug then. ;)

|

Mark Bramnik · Accepted Answer · 2012-06-28 07:40:48Z

0

I don't really understood why you all guys consider shippingAddresses at all? Vanathi said that the exception occurs while attempting to iterate over the

List addresses = getAllAddress();

in the for-each loop.

So there should be a thread that changes the array referenced by 'addresses'. BTW does the exception happen during the fist iteration or

You implementation of 'getAllAddresses' is as follows:

public List getAllAddress() { return allAddress; }

So I conclude that 'allAddresses' is just a data member of some class. This class obviously allows concurrent modification( another thread? ) This is where you should put your efforts... Just IMO :)

Hope this helps

answered Jun 28, 2012 at 7:40

Mark Bramnik

43k5 gold badges67 silver badges111 bronze badges

Collectives™ on Stack Overflow

java.util.ConcurrentModificationException Occurrs during List.add()

2 Answers 2

9 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related