Javascript Error: Returned is not defined

Question

Hi there I am having an issue in JSP where I wish to call a javascript function:

<c:forEach var='item' items='${bookLogs}' varStatus="status">
...

<tr >
    <td colspan="9"><a href="javascript:expandOrCollapse(${sectionNumber}, ${item.type.name});">
</tr>

...
</c:forEach>

Currently I firebug gives me an error: Returned is not defined. javascript:expandOrCollapse(1,%20Returned);()

How do I pass in just the textual value of item.type.name ???

Quote it.. "${item.blabla}".

Rob W
– Rob W

2012-06-29 17:10:45 +00:00
Commented Jun 29, 2012 at 17:10 — Rob W
– Rob W, Commented Jun 29, 2012 at 17:10

Salman Arshad · Accepted Answer · 2012-06-29 17:18:49Z

1

Apparently, ${item.type.name} is a string and therefore needs to be escaped and quoted, properly. If, for example ${item.type.name} is the string returned "value" & more, your HTML output should look like this:

<a href="javascript:expandOrCollapse(1, &quot;returned \&quot;value\&quot; &amp; more&quot;);">

edited Jun 29, 2012 at 17:18

answered Jun 29, 2012 at 17:13

Salman Arshad

274k85 gold badges450 silver badges540 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jbabey · Accepted Answer · 2012-06-29 17:19:12Z

1

You need to put quotes around the string or it will be treated as a javascript variable name:

<a href="javascript:expandOrCollapse(${sectionNumber}, '${item.type.name}');">
//                                                     ^     quotes      ^

You'll need to quote sectionNumber as well if it is a string. if it is a number, you don't.

answered Jun 29, 2012 at 17:19

jbabey

46.7k12 gold badges73 silver badges94 bronze badges

4 Comments

Ace Over a year ago

This seems to fix it on that page. But what gets displayed from the javascript running is "Returned". So it seems "Returned" the string is being passed in.

jbabey Over a year ago

@Ace i'm not sure what you mean, what behavior are you expected and what is it doing?

Ace Over a year ago

on the side of the javascript is was receiving the string "Returned" instead of the string that was contained in ${item.type.name}

jbabey Over a year ago

@Ace that means item.type.name has the value 'Returned', are you sure you're using the right property of your object?

Ace · Accepted Answer · 2012-06-29 18:19:29Z

0

The solution I came up with is a combination of jbabey and Salman A's answers. I added the quotes like jbabey suggested. But it sill needs to be HTML escaped like Salman A said, so I added f:escapeHtml function preceding the parameter and that worked.

answered Jun 29, 2012 at 18:19

Ace

8693 gold badges18 silver badges38 bronze badges

Collectives™ on Stack Overflow

Javascript Error: Returned is not defined

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related