Regex.Replace not replacing

Question

I have am using regex.replace to replace a '#' character with a Environment.Newline. However it is not returning the expected results. It is just returning the same input string. Here is my code.

Regex.Replace(inputString, @"#", Environment.NewLine);

Did you try var result = Regex.Replace(inputString, @"#", Environment.NewLine);? — Dr. Andrew Burnett-Thompson
– Dr. Andrew Burnett-Thompson, Commented Jul 5, 2012 at 13:35

Botz3000 · Accepted Answer · 2012-07-05 13:41:55Z

5

Regex.Replace doesn't change the parameter you passed in. It returns the results as a new string.

Try this:

inputString = Regex.Replace(inputString, @"#", Environment.NewLine);

Of course, Regex is a bit overkill for such a simple replacement. String.Replace would be enough in that case (note: String.Replace also doesn't modify the parameter, but returns a new string).

edited Jul 5, 2012 at 13:41

answered Jul 5, 2012 at 13:35

Botz3000

39.8k8 gold badges107 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tympaniplayer Over a year ago

Wow I feel dumb, that is it. It's only Thrusday morning and it has been a long day! Cheers!

Gabe · Accepted Answer · 2012-07-05 13:36:50Z

2

You don't need a RegEx for what you're doing, simpler:

inputString = inputString.Replace("#", Environment.NewLine);

answered Jul 5, 2012 at 13:36

Gabe

50.6k29 gold badges147 silver badges182 bronze badges

Comments

Neil Knight · Accepted Answer · 2012-07-05 13:37:10Z

0

As Dr. ABT mentioned, you need to return the Replace method into a variable. So, you could do:

inputString = Regex.Replace(inputString, @"#",Environment.NewLine);

This will update the inputString variable with the required replacements.

answered Jul 5, 2012 at 13:37

Neil Knight

48.8k26 gold badges136 silver badges193 bronze badges

Collectives™ on Stack Overflow

Regex.Replace not replacing

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related