Reading Multiple files in a Byte Array

Question

I have an object that has a byte array property 'ZipFile' to store a file stream:

Property in Result class:

public class Result
{
  public byte[] ZipFile;
}

In my application, I generate a PDF file, and read the file into the 'ZipFile' property using my ReadFile method like this :

objResult.ZipFile = ReadFile(FilePath);

Signature of ReadFile method:

private byte[] ReadFile(string strFileName)

The Problem:

My ReadFile method will now be called in a loop, because I am generating multiple PDF files. Each time the ReadFile method will read a new file from the specifed parameter to the 'objResult.ZipFile' property, consequently replacing the old value in 'ZipFile' property. Now, I want my 'ZipFile' property to store multiple PDF files stream. So what should I do for that? Should I just change this property to a two dimensional byte[][] array, or is there any better way to do this? Remember, that this property will be used for saving(writing) these files by calling method. Open to all Suggestions. Thanks.

Jon Skeet · Accepted Answer · 2012-07-06 07:43:56Z

4

Sounds like you should either have a List<Result>, or result should have a collection such as List<byte[]> as a ZipFiles property. Note that currently you don't have a property at all - you have a public field, which is generally a bad idea.

(You probably wouldn't expose it as a List<byte[]> - that would be the underlying implementation. I'd probably make it an IEnumerable<byte[]> and expose an AddZipFile method.)

answered Jul 6, 2012 at 7:43

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Ebad Masood Over a year ago

Thank you for your answer. I will be returning a Result object to the calling method, to Read the stream from its property. So, Why should I expose an AddZipFile method?

Jon Skeet Over a year ago

@ebad86: Well something has to add the byte array to the list - but it's generally a bad idea to expose whole lists as properties.

Ebad Masood Over a year ago

Thanks for the information. I am committing this mistake a lot. Although, I am desparate to learn why is it a bad idea. Is this topic mentioned in any of your articles or book? Can you please guide where I can learn more about this?

Jon Skeet Over a year ago

Yes, there are some guidelines around this in appendix B of C# in Depth, IIRC.

Habib · Accepted Answer · 2012-07-06 07:44:23Z

2

You may use List<byte[]> (list of byte array) and then append the array in the list in each iteration. Something like.

public class Result
{
   public List<byte[]> ZipFilesList { get; set; };
}

Later you can do:

ResultObj.ZipFilesList.Add(ReadFile(FilePath));

answered Jul 6, 2012 at 7:44

Habib

224k30 gold badges420 silver badges446 bronze badges

1 Comment

Ebad Masood Over a year ago

Thanks. I will do this and let you know.

IvoTops · Accepted Answer · 2012-07-06 07:49:26Z

1

If you just want to store them for later processing a list or queue will do it. I think I would opt for a queue as your usage pattern seems to match that.

 // make queue
 var filesQueue = new Queue<byte[]>();

 // add file
 filesQueue.Enqueue(newFile);

 // get file
 var fileToSave=filesQueue.Dequeue();

You can switch to a concurrentQueue later if you would ever need to parallelize etc..

answered Jul 6, 2012 at 7:49

IvoTops

3,54120 silver badges18 bronze badges

Comments

Asif Mushtaq · Accepted Answer · 2012-07-06 07:55:25Z

1

You need to have list of List<byte[]>

public class Result
{
   public List<byte[]> ZipFiles;
}

And add the files into your list

objResult.ZipFiles.Add(ReadFile(FilePath));

edited Jul 6, 2012 at 7:55

answered Jul 6, 2012 at 7:45

Asif Mushtaq

13.1k3 gold badges36 silver badges43 bronze badges

Collectives™ on Stack Overflow

Reading Multiple files in a Byte Array

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related