JavaScript using innerHTML and dynamic value passing to innerHTML

Question

var greentext='shopping';
var colors=new Array('green','blue','red','violet','brown');
for(i=0;i<colors.length;i++)
{
 //suppose consider colors[i] is green
}

When concatenating colors[i]+'text' and passing to some div using innerHTML, the string "greentext" is passed rather than the value of the concatenated string "shopping". How to pass the value of dynamically created string as above?

Hope my question is clear.....please help me

How are you trying to assign the value? Please update your example. — Felix Kling
– Felix Kling, Commented Jul 8, 2012 at 13:32
I tried to assign value as document.getElementById('somedivname').innerHTML=colors[i]+'text'; — user1510044
– user1510044, Commented Jul 8, 2012 at 14:55

Pointy · Accepted Answer · 2012-07-08 13:35:15Z

3

I'd do it completely differently:

  var text = {
    green: 'shopping',
    blue: 'contemplating infinity',
    red: 'cooking beans',
    violet: 'writing poetry'
  };

  var colors = ['green', 'blue', 'red', 'violet' ];
  for (var i = 0; i < colors.length; ++i) {
    alert( text[ colors[i] ] );
  }

Structured data should preferably be represented with actual structures in whatever programming language you're using. JavaScript is flexible enough that you can "construct" variable names, but it's not idiomatic. Here, I've made a simple object with properties corresponding to your colors.

answered Jul 8, 2012 at 13:35

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JavaScript using innerHTML and dynamic value passing to innerHTML

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related