Why does it return undefined? (Jquery xml parsing issue)

Question

I tried to populate a two dimensoinal array through parsing xml, but my function doesn't store the first items for some unknown reason. (So it stores [0][1] and [1][1] properly, but it does not store [0][0] and [0][1]);

The idea behind the array structure is:

first word-  >  first choice  ->[0][0]; 
first word  ->  second choice ->[0][1]; 
second word ->  first choice  ->[1][0];
... you can guess

It alerts everytime (just to check that counters are correct.)

The XML:

<?xml version="1.0" encoding="utf-8" ?>
 <Page>
  <Word id = "0">
    <Choice id = "0">
     <text>First word - 1. choice</text>
    </Choice>
    <Choice id = "1">
     <text>First word - 2. choice</text>
    </Choice>
  </Word>
 <Word id= "1">
  <Choices>
    <Choice id = "0">
      <text>Second word - First choice</text>
    </Choice>
    <Choice id= "1">
     <text>Second word - Second Choice</text>
    </Choice>
  </Choices>
 </Word>
</Page>

The function:

$(document).ready(function()
{
 $.ajax({
 type: "GET",
 url: "xml.xml",
 dataType: "xml",
 success: parseXml2
  });
});

function parseXml2(xml) {

var myArray = [];
var a = 0;

$(xml).find("Word").each(function() {
    var i = $(this).attr("id");
    a = 0;

    $(this).find("Choice").each(function() {
        alert('I:' + i + 'A:' + a);
        alert('Id:' + $(this).attr("id") + $(this).text());
        myArray[i] = [];
        var text = $(this).text();
        myArray[i][a] = text;
        a++;
    });
});

alert(myArray[0][0]);

}

parseXml2(xml);

The code can also be found here.

In future please include all relevant code in your post and don't just include a link to jsFiddle. Your post should standalone from any other resource; consider what'd happen if jsFiddle went down in the future. — Matt
– Matt, Commented Jul 9, 2012 at 9:44

19greg96 · Accepted Answer · 2012-07-09 10:02:41Z

1

It's because you set myArray[i] = []; on each iteration. Set it in this loop $(xml).find("Word").each(function() { not the second one. vágod :D?

this should work:

$(xml).find("Word").each(function() {
    var i = $(this).attr("id");
    a = 0;
    myArray[i] = [];
    $(this).find("Choice").each(function() {
        alert('I:' + i + 'A:' + a);
        alert('Id:' + $(this).attr("id") + $(this).text());

        var text = $(this).text();
        myArray[i][a] = text;
        a++;
    });
});

answered Jul 9, 2012 at 10:02

19greg96

2,5915 gold badges43 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1475728 Over a year ago

Thank you! :D I missed the obvious again.. (köszi wazze! :D)

19greg96 Over a year ago

azért ez nem volt annyira obvious :D egy ideig elszarakodtam vele :D

Py. · Accepted Answer · 2012-07-09 10:06:00Z

0

The problem in your code lies in the myArray[i] = []; line.

With this line, you're redefining the array at every iteration.

One solution to overcome that would be to write

if(typeof(myArray[i]) === "undefined"){
    myArray[i] = [];
}

in order to ensure you're not writting it if it exists

Updated fiddle

answered Jul 9, 2012 at 10:06

Py.

3,6091 gold badge36 silver badges55 bronze badges

Collectives™ on Stack Overflow

Why does it return undefined? (Jquery xml parsing issue)

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related