javascript getting index of nested function within function

Question

I have a function that sorts an array and within it, I have custom sort functions. Something like this:

function SortTheArray() {

  function SortCriteria1Asc(a, b) { ... }
  function SortCriteria1Dsc(a, b) { ... }
  function SortCriteria2Asc(a, b) { ... }
  function SortCriteria1Asc(a, b) { ... }

  var CustomSort;

  switch (SomeVar) {

     case 1:
       CustomSort = SortCriteria1Asc;
       break;

     case 2:
        CustomSort = SortCriteria1Dsc;
        break;

     case ....
  }

  SomeDataArray.sort(CustomSort);
}

Is it possible to remove the switch statement and say that the CustomSort function is simply equal to the nth nested function?

Thanks for your suggestions.

Do you really want to make this code even less readable?

GolezTrol
– GolezTrol

2012-07-09 15:16:00 +00:00
Commented Jul 9, 2012 at 15:16 — GolezTrol
– GolezTrol, Commented Jul 9, 2012 at 15:16
I find it quite readable; what's not clear?

frenchie
– frenchie

2012-07-09 15:16:38 +00:00
Commented Jul 9, 2012 at 15:16 — frenchie
– frenchie, Commented Jul 9, 2012 at 15:16
It is now, but will it be if you use those answers?

GolezTrol
– GolezTrol

2012-07-09 15:19:49 +00:00
Commented Jul 9, 2012 at 15:19 — GolezTrol
– GolezTrol, Commented Jul 9, 2012 at 15:19

Quentin · Accepted Answer · 2012-07-09 15:14:59Z

4

Don't give the function names, store them in an array.

var functions = [
  function (a,b) { ... },
  function (a,b) { ... },
  function (a,b) { ... }
];

Then just:

SomeDataArray.sort(functions[SomeVar]);

… but numerically indexed function identifiers don't sound like a very good idea. You would probably be better off using an object rather than array and giving them descriptive names.

answered Jul 9, 2012 at 15:14

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

GolezTrol Over a year ago

Too bad you even loose more context this way. Now you got SomeVar, having an Integer value, referring to an anonymous function X that apparently sorts in some way... Of course you can comment your code, but then you still got the same number of lines you got in the first place, only less readable.

frenchie Over a year ago

Can I keep the function's in the array name?

Quentin Over a year ago

@GolezTrol — Well yes, see the last paragraph of the answer.

Quentin Over a year ago

@GolezTrol — I edited in the advice about 30 seconds after answering the question.

frenchie Over a year ago

ok, I left the arrays without the function name and to keep the code easy to understand, I just added the name of the function as a comment. Thanks

bokonic · Accepted Answer · 2012-07-09 15:15:57Z

3

Why don't you defined the inner functions in an object indexed by the variable you are switching by?

function SortTheArray(someVar){

   var sorters = {
       CriteriaA: function(array){ ... };
   };
   return sorters[someVar];
};

answered Jul 9, 2012 at 15:15

bokonic

1,77110 silver badges12 bronze badges

1 Comment

GolezTrol Over a year ago

+1 for providing code that shows at least a little clarity by itself.

Denys Séguret · Accepted Answer · 2012-07-09 15:14:52Z

1

You can simply build your functions directly in an array :

function SortTheArray() {
   var functions = [];
   functions.push(function(a,b) { ... });

Then you can execute functions[i](a,b).

answered Jul 9, 2012 at 15:14

Denys Séguret

384k90 gold badges813 silver badges779 bronze badges

Collectives™ on Stack Overflow

javascript getting index of nested function within function

3 Answers 3

5 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related