Code sticks in loop, whats wrong?

Question

I have this code and it's getting stuck in a loop. I have similar codes and it loops through the doc changing each word only once. When I run this sub it sticks on the first instance and replaces the text over and over.

I want it to find the word "therefore" and if the previous "word" = ; to skip, otherwise change to "therefore (needs joined with ;)".

What am I missing/doing wrong?

Thanks in advance!

 Sub test()

 Dim wrd As Range
 For Each wrd In ActiveDocument.Words
    If InStr(1, wrd, "therefore") <> 0 Then
        If InStr(1, wrd.Previous(Unit:=wdWord, Count:=1).Text, ";") <> 0 Then
        Else
            wrd.Text = "therefore (needs joined with ;)"
        End If
    End If
Next
End Sub

Have you stepped through your code in debug mode to see what's going on? — Gaffi
– Gaffi, Commented Jul 9, 2012 at 15:58
Doesn't calling wrd.Previous move the selection pointer back to the previous word? Looks like you are getting to a word, then moving the selection back a word and checking it again. Try calling wrd.Next() after your wrd.Previous() — Charleh
– Charleh, Commented Jul 9, 2012 at 16:00
You would be better off using the .Find method of the Document, a defined range or the selection, if you are trying to replace text. I believe what is happening is that you put in new words that haven't been through the "For Each" loop, and that it is finding "therefore" in that set of new words, and replacing it, then doing it again with the new "therefore" word you just put it. Why not just record a Find and Replace macro in Word? — Michael Blaustein
– Michael Blaustein, Commented Jul 9, 2012 at 18:41

Charleh · Accepted Answer · 2012-07-09 19:43:54Z

2

e.g. try this - as I suspect you are jumping back to the previous word and you are checking it over and over again, the Word DOM is quite a strange one...!

Sub test() 

 Dim wrd As Range 
 For Each wrd In ActiveDocument.Words 
    If InStr(1, wrd, "therefore") <> 0 Then 
        If InStr(1, wrd.Previous(Unit:=wdWord, Count:=1).Text, ";") = 0 Then 
            wrd.Text = "therefore (needs joined with ;)" 
        End If 

        wrd.Next Unit:=wdWord, Count:=1
    End If 
Next 
End Sub

edited Jul 9, 2012 at 19:43

answered Jul 9, 2012 at 16:02

Charleh

14k3 gold badges41 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

MBlackburn Over a year ago

It's saying wrd.Next(Unit:=wdWord, Count:=1) is invalid syntax? Did you get that same error?

Charleh Over a year ago

Try without the parenthesis, vb only requires parenthesis when the methods return value is used

Gaffi Over a year ago

@Charleh Or when Call is explicitly used, but why would you do that? ;-)

Charleh Over a year ago

Too much coffee maybe? VB makes me shudder.... the boss still uses it though.. when writing NEW apps! Argh!

Collectives™ on Stack Overflow

Code sticks in loop, whats wrong?

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related