Java and MySQL INSERT

Question

I have set up a program for an enterprise to handle their brochures(catalogo in spanish). I ask the user via Swings for the data, and then use it to generate a query and insert it into my db. Here is the code:

                    Class.forName(driver);
                con = DriverManager.getConnection(url + db, user, pass);
                con.setAutoCommit(false);
                st = con.createStatement();

                String sql = "INSERT INTO `catalogos` (`id`, `name`, `keywords`) VALUES(" + catNumIn.getText() + ", '" + catNameIn.getText() + "', '" + catKeyIn.getText() +  "');";
                st.executeUpdate(sql);

So i would like to know what my error is. Thank you!

Sorry for not saying, the error is that the data isnt inserted to the table — user1178729
– user1178729, Commented Jul 11, 2012 at 10:12
Also it is more safe to use prepared statement (no sql injection). private static final String SQL_INSERT = "INSERT INTO 'catalogos' ('id', 'name', 'keywords') VALUES (?, ?, ?)"; — Alex Nevsky
– Alex Nevsky, Commented Jul 11, 2012 at 10:34

Simon Nickerson · Accepted Answer · 2012-07-11 10:15:24Z

2

Are you committing your transaction? You've said setAutoCommit(false) after all. Could you try:

setAutoCommit(true);

instead of the line you currently have, or:

con.commit();

after your database update?

answered Jul 11, 2012 at 10:15

Simon Nickerson

43.3k21 gold badges107 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1178729 Over a year ago

As i said i'm quite new to programming. Could you tell me what a commit is?I don't know what it is so I don't know if it is wrong

Madhivanan · Accepted Answer · 2012-07-11 10:14:54Z

0

When you construct sql statement in your front end and have an error, the best approach is to print the variable and see if there is a problem with the values like single quotes,missing comma,etc

answered Jul 11, 2012 at 10:14

Madhivanan

13.7k1 gold badge28 silver badges30 bronze badges

Collectives™ on Stack Overflow

Java and MySQL INSERT

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related