javascript syntax - passing variable to function

Question

var testvar = "something";

//only one of the following 3 lines were uncommented while testing:
var myinsert = '<span class="green myCursor" 
                   onClick="getproblemsadmin(testvar)">
                   Test
                </span>'; //doesn't pass testvar to function

var myinsert = '<span class="green myCursor" 
                   onClick="getproblemsadmin(\'testvar\')">
                   Test
                </span>'; //doesn't pass testvar to function

var myinsert = "<span class='green myCursor' 
                   onClick='getproblemsadmin(\"testvar\")\'>
                   Test
                </span>"; //doesn't pass testvar to function

$('.someclass').html(myinsert); //jquery works and this works (tested)

Is there a way to pass a variable to function like this?

Do you want the value of testvar at the time of creating the string and setting the HTML, or at the time of the actual onclick event execution? — Simon Forsberg
– Simon Forsberg, Commented Jul 14, 2012 at 13:13
at the time of creating the string. The first answer that was posted is correct. — GTCrais
– GTCrais, Commented Jul 14, 2012 at 13:23

Besnik · Accepted Answer · 2012-07-14 13:08:27Z

2

Do you mean the value of this variable?

var myinsert = "<span class='green myCursor' onClick='getproblemsadmin(\""+testvar+"\")\'>Test</span>";

The syntax:

var myinsert = "string" + variable + "string";
var myinsert = 'string' + variable + 'string';

answered Jul 14, 2012 at 13:08

Besnik

6,5581 gold badge33 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

GTCrais Over a year ago

The value, yes. Thanks, I will try this out now.

GTCrais Over a year ago

This works, thanks! (I would edit my previous comment but I can't anymore)

JoshMock Over a year ago

Richard's jQuery solution is wiser, safer and faster than building a string, especially if that string includes JavaScript that will later be evaluated.

Richard · Accepted Answer · 2012-07-14 13:24:54Z

1

You could try creating the span element and then binding the click event:

$('<span class="green myCursor">Test</span>').click(function()
{
    getproblemsadmin('testvar')
});

or, if you wanted to get really jQuery'esk, you could write:

$('<span />').addClass('green myCursor').text('test').click(function()
{
    getproblemsadmin('testvar')
});

answered Jul 14, 2012 at 13:24

Richard

8,2903 gold badges39 silver badges60 bronze badges

Comments

user188654 · Accepted Answer · 2012-07-14 13:12:03Z

0

If I understood you correctly you are looking for a way to pass a variable to a function which will return a constructed string containing markup code? Something like this?

var testvar = "something";

var myinsert = work_horse(testvar);
$('.someclass').html(myinsert);

function work_horse(testvar){
    return '<span class="green myCursor" onClick="getproblemsadmin(' + testvar + ')">Test</span>';
}

answered Jul 14, 2012 at 13:12

user188654

Collectives™ on Stack Overflow

javascript syntax - passing variable to function

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related