0

I am trying to use some javascript inside a form to get the value from a select dropdown box, and use it another part of the form. I cannot figure out the syntax.

first the javascript function (I placed this at the end of my view):

<script type="text/javascript">
  function return_event_id()
  {
    var event_id = document.getElementById("event_id");
    return event_id.value;
  }
</script>

Inside the view, I have the following: 

<%= select("discount_code", :event_id, events_ids_titles_hash, { :include_blank => true }) %>

If I add the following statement:

return_event_id

Then the dropdown item I selected is displayed on the form (although I also see the word return_event_id as well).

If I do something like this:

<% selected_event_id =  return_event_id %>

I get the following error message: undefined local variable or method `return_event_id'

What I'm looking for is to be able to store the event_id value in a variable. What's the proper syntax?

Additional details and comments on answer:

1: Yes, Ruby code = server, javascript code = client

2: Putting the code in something like application.js would move it out of the view.erb module, but as far as I know, it does not change the outcome.

I understand that <% selected_event_id = return_event_id %> will not work, but I do need to get to a point where I can somehow pass the output from return_event_id back to the server, and then capture it in a Ruby variable, OR, if there is a way to use the javascript function output to set another element in the form.

Improve this question
2
  • You're trying to call a javascript function (run on the browser) from a ruby statement (run on the server before the client even knows there's a response)? No syntax in the world will fix that. Commented Jul 16, 2012 at 12:19
  • what is Selected_event_id is it a textbox(html) or something on the server side ? Commented Jul 16, 2012 at 12:26

2 Answers 2

Reset to default
4

For starters, it's best to separate your javascript from your view:

Write your js in a separate file, put it in public or your assets dir depending on your rails version.. Then if you are in raila 3.1+ it will get auto loaded with your assets, if below 3.1 add the following to your view ( at the top )

<%= javascript_include_tag "my_javascript_filename" %>

From there you could create an ajax request back to your rails app (wich means writing controller code and a route to handle this) to get the list of items you want:

http://net.tutsplus.com/tutorials/javascript-ajax/5-ways-to-make-ajax-calls-with-jquery/
I'd recommend using the getJSON method form the above URL

Improve this answer
Sign up to request clarification or add additional context in comments.

7 Comments

And this will allow you to call a javascript function from ruby?
You cannot call a js function from Ruby. Ruby is being run on the server, js is on the client.
You could send the info back to the server with an ajax call.
Yes, you could. Maybe instead of an answer that doesn't address the question at all you'd consider writing up something that explains the OP's error and addresses solving the problem.
Please see edits to my question. Other than moving the function to another file, the issue is not addressed. If it could be passed back to the server through an Ajax call, I would appreciate a pointer/example.
|
1

To let your JavaScript function to be called, you have two options:

1) straight-forward:

let the select_tag generate an html-attribute "onchange"

select("discount_code", :event_id, events_ids_titles_hash, { 
    :include_blank => true, 
    :onchange => "fill_my_event_data();"
    }

and then write a JavaScript function "fill_my_event_data" that uses your return_event_id() and then puts data you need in the form elements you want.

2) use "unobtrusive JavaScript" with jQuery. Then you don't need to do much in rails (except providing correct ids and data-attributes). You do everything in your bottom JavaScript section. You connect the select tag with an event handler that again calls your function. But of course you need to learn the basics of jQuery. If you need to do such things often, the jQuery knowledge is useful.

Improve this answer

2 Comments

soory, I had submitted an uncomplete answer
Thank you. I am aware of the onchange syntax, but I was messing up the getElementById syntax (setting it to a value). The correct way would be something like this: document.getElementById("old_event_id").value=return_event_id

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.