implode an array into a comma separated string from mysql query

Question

For the last 1 1/2 days I've been trying to store 16 row id's into a string and separate each id with a comma. The array I am getting is from MySQL. The error I am getting is

implode() function:passed invalid arguments

$str=array();
$string="";
while($row = mysql_fetch_row($result)) 
{
    $user_id=$row;
    $str=$user_id;
    foreach($str as $p=>$v){
        comma($v);
    }
}

function comma($v){
    $string= implode(",",$v); echo $string;
}

Please, stop being a bad guy and do not store comma-separated values into a unique field. Use another table and store each value into its own row. (You are creating problems that wouldn't exist if your shema was well structured.) — OcuS
– OcuS, Commented Jul 22, 2012 at 11:36
@oCuS I don't know if he's trying to "store comma-separated values into a unique field", he just says he want to store it into a string. — Leon
– Leon, Commented Jul 22, 2012 at 11:43
@Leon: "I've been trying to store 16 row id's into a string and separate each id with a comma". It says enough to me. That's a bad design. Period. — OcuS
– OcuS, Commented Jul 22, 2012 at 11:45
Also, you shouldn't be using the mysql_* functions, since they're a) insecure, and b) being deprecated (see the red box). You should be using prepared statements with PDO or MySQLi instead. — Ricardo Altamirano
– Ricardo Altamirano, Commented Jul 22, 2012 at 11:53

huysentruitw · Accepted Answer · 2016-03-19 07:37:09Z

17

Try something like this:

$ids = array(); 
while ($row = mysql_fetch_assoc($result))  
{
    $ids[] = $row["UserID"]; 
} 
echo implode(", ", $ids);

Replace "UserID" with the columnname of the id in your table.

So: first you build the array, next you implode the array into a string.

edited Mar 19, 2016 at 7:37

answered Jul 22, 2012 at 11:40

huysentruitw

28.2k10 gold badges95 silver badges141 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

perfectio · Accepted Answer · 2016-08-08 21:27:24Z

3

There is my solution:

SELECT GROUP_CONCAT(UserID) as string  FROM Users;

For this function the delimiter is ',' by default.

edited Aug 8, 2016 at 21:27

answered Aug 5, 2016 at 22:26

perfectio

693 bronze badges

Comments

Darwin · Accepted Answer · 2017-05-11 12:17:11Z

0

$query = 'SELECT id FROM your_table';
$rs = mysql_query($query);

$row = mysql_fetch_array($result);
return implode(',', $row);

the result 1,2,3...

answered May 11, 2017 at 12:17

Darwin

872 silver badges8 bronze badges

Collectives™ on Stack Overflow

implode an array into a comma separated string from mysql query

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related