PHP Function Variable Pass Through

Question

Rusty, just simply trying to pass stuff through parameters. What am I doing wrong?

//Insert into DB
function insert(x,y,z)
mysql_query("INSERT INTO x (y)
VALUES ('z')");


insert("test","name","Tyler");

You're doing wrong everything. Have you read this: nz.php.net/manual/en/functions.user-defined.php ? — zerkms
– zerkms, Commented Jul 22, 2012 at 20:36
You forgot to use $ to sinalize the variables and curly braces in the function scope — Marcio Mazzucato
– Marcio Mazzucato, Commented Jul 22, 2012 at 20:37
Please don't use mysql_* functions in new code. They were removed from PHP 7.0.0 in 2015. Instead, use prepared statements via PDO or MySQLi. See Why shouldn't I use mysql_* functions in PHP? for more information. — tereško
– tereško, Commented Jul 22, 2012 at 20:39
What error messages do you get when you try to run the code you posted? — user212218
– user212218, Commented Jul 22, 2012 at 20:40

cyborg86pl · Accepted Answer · 2012-07-22 20:37:46Z

4

function insert($x,$y,$z){
    mysql_query("INSERT INTO ".$x." (".$y.") VALUES ('".$z."')");
}
insert("test","name","Tyler");

answered Jul 22, 2012 at 20:37

cyborg86pl

2,6153 gold badges28 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user1361154 Over a year ago

Much more confusing than I remember, thanks! Why the dots around the variables?

Robert Over a year ago

. concatenates the variables with your string. Since you are using double-quotes, concatenation is not necessary and the variables can be placed directly into the string and will be evaluated correctly.

cHao Over a year ago

The dot is PHP's string concatenation operator. You could also do like "INSERT INTO $x ($y) VALUES ('$z')" if you wanted, but some people don't like that for some reason. Though i'd argue if they don't like it, they shouldn't be sticking all their strings in double quotes...cause then interpolation will only happen when you don't want it to. :P

cyborg86pl Over a year ago

yeah, i have that habit and like it being colored in editors.

user1361154 Over a year ago

What would be the new way to retrieve data from sqldatabase and turn it into text and echo? Use to be hell.

Robert · Accepted Answer · 2012-07-22 20:39:08Z

1

Be sure you are referencing the variable correctly via $:

//Insert into DB
function insert($x, $y, $z)
{
    mysql_query("INSERT INTO $x ($y) VALUES ('$z')");
}


insert("test","name","Tyler");

edited Jul 22, 2012 at 20:39

user212218

answered Jul 22, 2012 at 20:38

Robert

8,7672 gold badges29 silver badges34 bronze badges

4 Comments

user1361154 Over a year ago

Yea, I think I was doing it kind of javascripty . Thanks

Robert Over a year ago

You're welcome. It's helpful that you always debug your code to ensure that the desired result is occurring properly.

Robert Over a year ago

The purpose of debugging is not always to identify bugs. Debugging in itself means to remove errors and to see into the execution of a program by examining it. It is the second part that I was referring to.

user1361154 Over a year ago

What would be the new way to retrieve data from sqldatabase and turn it into text and echo? Use to be hell.

Collectives™ on Stack Overflow

PHP Function Variable Pass Through

2 Answers 2

5 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related