problem finding file w/ php

Question

I have a database which is tied to a server of pictures. In the case that a pic isn't uploaded I want to place an "unavailable" photo in its place. Each pic is in numerical order based on the primary key from the database $row['Item_ID']. My script below searches for the file but can't find any pics, so it uses the "unavailable" for everything. I am not sure if I can use double quotes on the first line when I write '$row["Item_ID"]'.

$img_var = '$row["Item_ID"]';
$item_img = '/item_images/$img_var.jpg';         
if (!file_exists($item_img))        
{ $row['Item_ID'] = 'unavailable'; }     
else { $row['Item_ID'] = $row['Item_ID']; }

Peter Bailey · Accepted Answer · 2009-07-21 20:17:15Z

5

Your first two lines are needlessly performing (or attempting-to perform) string replacement.

Single-quote delimited strings aren't interpolated for variables or escape sequences.

But really, you're emaking this overly complex - just concatenate the filepath on a single line and and fail-over to your unavailable image when you need to.

$item_img = '/item_images/' . $row["Item_ID"] . '.jpg';
if ( !file_exists( $item_img ) )
{
  $item_img = '/item_images/unavailable.jpg';
}

answered Jul 21, 2009 at 20:17

Peter Bailey

106k32 gold badges186 silver badges206 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

EFraim · Accepted Answer · 2009-07-21 20:12:32Z

2

Single quotes are not interpolated.

answered Jul 21, 2009 at 20:12

EFraim

13.1k4 gold badges48 silver badges64 bronze badges

Comments

Mark Biek · Accepted Answer · 2009-07-21 20:13:07Z

2

This

$img_var = '$row["Item_ID"]';
$item_img = '/item_images/$img_var.jpg';

needs to read

$img_var = $row["Item_ID"];
$item_img = "/item_images/$img_var.jpg";

or even

$item_img = "/item_images/{$row["Item_ID"]}.jpg";

When it's inside single-quotes, PHP doesn't resolve $img_var to its value, it just uses the string "$img_var".

answered Jul 21, 2009 at 20:13

Mark Biek

152k54 gold badges160 silver badges201 bronze badges

Comments

mpen · Accepted Answer · 2009-07-22 02:15:30Z

0

$item_img = '/item_images/'.$row['Item_ID'].'.jpg';
if(!file_exists($path_to_root.$item_img)) {
    $item_img = '/item_images/unavailable.jpg';
}

Note the $path_to_root. Your HTML root is not the sames as your PHP root (unless your server is specifically configured that way... mine isn't), so you have to make sure the paths are correct. I like to place a PHP file sitting at the base of my site with define('ROOT', dirname(__FILE__)); and then you can just do ROOT.'/path/to/whatever.jpg'.

answered Jul 22, 2009 at 2:15

mpen

285k289 gold badges896 silver badges1.3k bronze badges

Collectives™ on Stack Overflow

problem finding file w/ php

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related