Remove spaces in file names apache

Question

1.Hi, I have a internal use only file upload script that uploads the files to a directory. When I upload something from my computer with a spcace in the name i.e example 1.zip it uploads with a space in the name thus killing the link in a email. Is it possible to make apache remove the space when its uploaded or make it a underscore?

The second problem I am having is how would I parse this to make the link an email link with the url of the file as the body of the email amd the email addy anything?

if (move_uploaded_file($_FILES['file']['tmp_name'], $uploaddir . $_FILES['file']['name'])) {
    // uploaded file was moved and renamed succesfuly. Display a message.
    echo "Link: " . "http://example.org/" . $_FILES["file"]["name"];

soulmerge · Accepted Answer · 2009-07-22 18:35:25Z

7

You just need to urlencode() your file name and everything is fine:

echo "Link: http://example.org/" . urlencode($_FILES["file"]["name"]);

But if you want to remove the spaces for another reason, you can use str_replace():

$replaced_name = str_replace(' ', '_', $_FILES["file"]["name"]);
rename($uploaddir . '/' . $_FILES['file']['name'], $uploaddir . '/' . $replaced_name);
# You should urlencode() it nonetheless:
echo "Link: http://example.org/" . urlencode($replaced_name);

edited Jul 22, 2009 at 18:35

answered Jul 22, 2009 at 18:23

soulmerge

76.2k20 gold badges121 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

hnhh Over a year ago

How would I make it so I could use that link as a mailto like the link would go on the body and anything would be in the message

soulmerge Over a year ago

Have a look at the examples section of the according RFC: tools.ietf.org/html/rfc2368#section-6

Nathan · Accepted Answer · 2009-07-22 18:38:59Z

1

Try:

$filename = $_FILES['file']['name'];
$filename = preg_replace("/[^a-zA-Z0-9]/", "", $filename);

//then
if (move_uploaded_file($_FILES['file']['tmp_name'], $uploaddir . $filename)) {

// uploaded file was moved and renamed succesfuly. Display a message.
echo "Link: " . "http://example.org/" . $filename;

edited Jul 22, 2009 at 18:38

answered Jul 22, 2009 at 18:24

Nathan

4,0672 gold badges27 silver badges20 bronze badges

4 Comments

hnhh Over a year ago

Thanks! any ide on how I would do an email like thing

Nathan Over a year ago

You want to send this link for an email?

hnhh Over a year ago

Basically I want it to echo a mailto:[email protected] with the body text at the link .

Nathan Over a year ago

You can use mailto:[email protected]?body=example.com/file.zip. For a complete reference on mailto check: ianr.unl.edu/internet/mailto.html :)

Pascal MARTIN · Accepted Answer · 2009-07-22 21:14:03Z

As a side note : with the code you are using, what is happening if two files with the same name are uploaded ? If you don't do a check (like "is there a file that already has that name in $uploaddir ?") the second file will replace the first one.

That might not be something you want... is it ?

If not, to solve that (potential) problem, one solution is to always rename uploaded files, with names you control. (A simple counter would probably to the trick)

Another thing is : $_FILES["file"]["name"] is sent by the client, and, as such, can probably be forged to contains whatever someone would want. If it contains something like "../../index.php" (or something like this - you get the idea), this could allow someone to put any file they want on your server.

To prevent this from happening, you shoud be sure the file name/path used as destination of move_uploaded_file does not contain anything "dangerous". A solution could be to use basename. (see, for instance, example #2 on POST method uploads)

You might also want to check the mimetype of the uploaded file, so you don't get executables, for instance -- and you should make sure files uploaded are not executable by the webserver.

Collectives™ on Stack Overflow

Remove spaces in file names apache

3 Answers 3

2 Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related