php data testing

Question

I have the following test on some data:

if(isset($option_type)
    && ($option_type == 3 || $option_type == 4
                && (isset($ext_data) && $ext_data != "")
                )
  ){}

What it should do, is if $option type is NOT 3 or 4, the test should return true. If $option type is 3 or 4 AND $ext_data does not exist or equals "", then the test should return false.

However, no matter what $option_type is, it returns false.

How can I format this test so when the $option_type is 3 or 4 and $ext_data exists and is not "", the result is true?

lee

a quick suggestion here, separate them out and return them, see what they return (true or false), then organize the order from there — lusketeer
– lusketeer, Commented Jul 27, 2012 at 2:58
Two words: operator precedence. It might not immediately fix your test, but the current code is most likely not what you want. — Palladium
– Palladium, Commented Jul 27, 2012 at 3:12
I know a little about operator precedence. However, I'm not sure that applies here since all the outer testing uses && and the inner testing is parenthesized. Is this correct or am I missing something? — Lee Loftiss
– Lee Loftiss, Commented Jul 27, 2012 at 3:16
The && on your third line only applies if $option_type == 4. Due to lazy logic, if $option_type == 3 the code won't even bother computing the third line. — Palladium
– Palladium, Commented Jul 27, 2012 at 3:19
Thanks Palladium. I just did a bunch of reading and understand a little more. I still am not clear exactly why my test is not working, but I got some new knowledge for future use. — Lee Loftiss
– Lee Loftiss, Commented Jul 27, 2012 at 3:25

laurent · Accepted Answer · 2012-07-27 03:01:05Z

2

I would split the tests into two to make it clearer:

if (!isset($ext_data) || $ext_data == "") return false;
return $option_type != 3 && $option_type != 4;

answered Jul 27, 2012 at 3:01

laurent

91.2k83 gold badges310 silver badges445 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lee Loftiss Over a year ago

Hello, I can do this, no problem. But I am curious to know why the test as it is does not work or what is not clear about it. I've used similar testing in ActionScript and C# with no problem. Is it a PHP thing? Is it just incorrect?

Abid Hussain · Accepted Answer · 2012-07-27 04:55:10Z

0

//try this

if(isset($option_type)&& ($option_type == 3 || $option_type == 4)){
    if (isset($ext_data) && $ext_data == ""){
            return false;
    }else{
        return true;
    }

  }

answered Jul 27, 2012 at 4:55

Abid Hussain

7,7694 gold badges38 silver badges57 bronze badges

Collectives™ on Stack Overflow

php data testing

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related