I am unable to catch exception in php code

Question

I have following piece of code:

function doSomething()
{
     try {
         doSomeNastyStuff() // throws Exception
     } catch(\Exception $e) {
         if ($this->errorHandler) {
             call_user_func($e);
         } else {
             throw($e);
         }
     }
}

However, the catch block does not work. The stack trace shows me the error happened at the line doSomeNastyStuff(). Where is the problem?

Samuel Hapak · Accepted Answer · 2012-07-27 08:31:16Z

5

The problem is, you are rethrowing your Exception. The stack trace is part of the Exception instance and is recorded at the moment, exception is created. You can get the stack trace by

 $e->getTrace(); // Exception $e

When you rethrow exception in your code, it still has the old stack trace recorded and this tricks your framework to show you, the exception actually happened at the line doSomeNastyStuff() and it seems like the catch does not work.

Therefore, it is better idea to rethrow exceptions the following way:

/** instead of throw($e) do */
throw new \Exception("Unhandled exception", 1, $e);

Beginining with php5.3, Exception constructor has optional third parameter $previous exactly for this purpose. You can then get the previous Exception using $e->getPrevious();

edited Jul 27, 2012 at 8:31

answered Jul 27, 2012 at 8:08

Samuel Hapak

7,2845 gold badges41 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

I am unable to catch exception in php code

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related