node.js MongoDB query not returning results

Question

I was playing around with mongodb and entered some test data {name:"david"} into the 'users' collection. I verified that the data was in MongoDB using the mongo shell by typing

db.users.find()

result:

{ "name":"david" }

In node.js script, the following code:

db.open(function(err, db) {
    if (!err) {
        console.log("db opened!");
    }
    else {
        console.log(err);
    }
    db.collection('users', function(err, collection) {
        collection.find({}, function(err, cursor) {
            cursor.each(function(err, item) {
                console.log(item);
            });
        });
    });
    db.close();
});

does not return any results

I don't see anything wrong, and no err returns. Please advise

cjohn · Accepted Answer · 2012-07-28 00:24:40Z

10

You're actually closing your database connection before data from the collection has returned.

db.collection('users', function(err, collection) {
  collection.find({}, function(err, cursor) {
    cursor.each(function(err, item) {
      console.log(item);
    });

    // our collection has returned, now we can close the database
    db.close();
  });
});

answered Jul 28, 2012 at 0:24

cjohn

11.7k3 gold badges32 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Leon Stankowski · Accepted Answer · 2012-07-29 06:36:04Z

As CJohn states correctly you are closing the DB connection BEFORE you retrieve the data. I know it doesn't look like it but this is the case with Node structure and callbacks. The code to correctly handle this is:

db.open(function(err, db) {
    if (err) return console.log('error opening db, err = ', err);

    console.log("db opened!");

    db.collection('users', function(err, collection) {
        if (err) return console.log('error opening users collection, err = ', err);

        collection.find({}, function(err, cursor) {
            if (err) return console.log('error initiating find on users, err = ', err);

            cursor.each(function(err, item) {
                // watch for both errors and the end of the data
                if (err || ! item) {
                    // display (or do something more interesting) with the error
                    if (err) console.log('error walking data, err = ', err);

                    // close the connection when done OR on error
                    db.close();

                    return;
                }
                console.log(item);
            });
        });
    });
});

bryanmac · Accepted Answer · 2012-07-28 12:32:10Z

This pattern is working fine in my node/mongo sample. The function is passed a callback which takes err, collection. It gets the 'users' collection and if successful, calls find against the collection and converts it to an array but you can iterate on the cursor as well.

Inside the db.collection and the connection.find calls, you're not checking for err and handling. You're only doing it on the open call.

Also, you shouldn't call db.close() especially if you're opening with connection pool option (you don't want to open and close the connection on every call). If you did want to close, then close inside the callback.

Something like:

var server = new Server(host, port, {auto_reconnect: true, poolSize: 5}, {});

MyStore.prototype.getUsers = function(callback) {
server.open(function(err, db) {
    if (err) {
        callback(err);
    }
    else {
        db.collection('users', function(err, collection) {
            if( err )
                callback(err);
            else {
                collection.find().toArray(function(err, users) {
                    if (err) {
                        callback(err)
                    } else {
                        callback(null, users);
                    }
                });
            }
        }
    }});

Here's another tutorial on node + mongo that may help: http://howtonode.org/express-mongodb

Vaisakh VM · Accepted Answer · 2013-08-07 08:32:18Z

3

Try upgrading your node to latest version.

sudo npm cache clean -f
sudo npm install -g n
sudo n stable

version 0.4 may not work properly.

edited Aug 7, 2013 at 8:32

answered Aug 7, 2013 at 6:55

Vaisakh VM

1,07711 silver badges9 bronze badges

Collectives™ on Stack Overflow

node.js MongoDB query not returning results

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related