CodeIgniter model method not returning value to controller

Question

I'm using the count_all_results() function to return a user's number of languages spoken. But when I try to pass the number to the view, I keep getting a php undefined variable (for $lang_cnt). Below is my code:

Model

function countLanguages($id, $cnt_languages) {
    
    $this->db->where('user_id', $id)->from('languages');
    $cnt_languages = $this->db->count_all_results();
}

Controller

function showLangCount() {

    $data['lang_cnt'] = $this->language_model->countLanguages($cnt_languages);
                        
    $this->load->view('lang_view', $data);
}

View

<p>This user speaks <?php echo $lang_cnt; ?> languages.</p>

Mischa · Accepted Answer · 2012-07-31 16:58:52Z

2

One problem is that your model function takes two arguments:

function countLanguages($id, $cnt_languages)

But when you call it you are only passing one argument:

$this->language_model->countLanguages($cnt_languages);

And an even bigger problem, as Rocket points out, is that countLanguages doesn't return anything. Try this:

function countLanguages($id) {
  $this->db->where('user_id', $id)->from('languages');
  return $this->db->count_all_results();
}

edited Jul 31, 2012 at 16:58

answered Jul 31, 2012 at 16:52

Mischa

43.4k9 gold badges101 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

gen_Eric Over a year ago

Also, countLanguages doesn't return anything.

Mischa Over a year ago

@Rocket, thanks, that is indeed the cause of the problem. If you add it as an answer I will upvote and delete mine.

chowwy Over a year ago

@Mischa - Thanks for your response. I've added the return language as suggested, and removed the 2nd argument. But I'm still getting the same error. I've updated my code to show the changes.

chowwy Over a year ago

@Rocket - Thanks; I've added the return, but still get the same error. The code in my question has been updated to show the changes.

Mischa Over a year ago

@chowwy, where is the $id in your controller coming from? Apart from not seeing where $id comes from I don't see any problems with the code you have posted. Could you show your complete code?

|

Jamshid Hashimi · Accepted Answer · 2012-07-31 23:58:50Z

0

Always check your model functions if they return value or not. Try this:

function showLangCount() {
    if($this->language_model->countLanguages($id))
    {
        $data['lang_cnt'] = $this->language_model->countLanguages($id);
    }
    else
    {
        $data['lang_cnt'] = NULL;
    }

    $this->load->view('lang_view', $data);
}

answered Jul 31, 2012 at 23:58

Jamshid Hashimi

7,8512 gold badges31 silver badges28 bronze badges

1 Comment

Mischa Over a year ago

$this->db->count_all_results(); always returns an integer, so this should not be necessary.

GautamD31 · Accepted Answer · 2012-08-21 11:48:01Z

0

Its better to use:

return $query->num_rows();

to return the number of rows effected...

answered Aug 21, 2012 at 11:48

GautamD31

28.8k10 gold badges66 silver badges86 bronze badges

Collectives™ on Stack Overflow

CodeIgniter model method not returning value to controller

3 Answers 3

10 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

10 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related