using array as function parameter

Question

i am a beginner in c. i don't know that much how to use arrays as function parameters, arguments or how to return array from an function. to my knowledge, the below code should work fine. But i can't get where the problem is. the function is not working as it should.

//reversing an array using function
#include<stdio.h>
void rev(int array[],int length)
{
    int k,j,temp;
    for(k=length-1,j=0;k>=0&&j<length;k--,j++){
        temp=array[k];
        array[k]=array[j];
        array[j]=temp;
    }
}
int main()
{
    int c,arr[]={1,2,3,4,5,6,7,8,9};
    rev(arr,9);
    for(c=0;c<9;c++){
        printf("%d ",arr[c]);
    }
    return 0;
}

In fact you can't directly pass an array as a function argument, or return one as a function result. The parameter declaration int array[] really means int *array, a pointer (this applies only to parameter declarations). Suggested reading: section 6 of the comp.lang.c FAQ. — Keith Thompson
– Keith Thompson, Commented Aug 6, 2012 at 9:39

MByD · Accepted Answer · 2012-08-06 08:45:00Z

3

You only need to go until the middle of the array, if you go more, you re-reverse the array:

So this:

for(k=length-1,j=0;k>=0&&j<length;k--,j++){

Should be:

for(k=length-1,j=0;k > j;k--,j++){

answered Aug 6, 2012 at 8:45

MByD

138k30 gold badges269 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nasif Imtiaz Ohi Over a year ago

thanks very much. i just figured myself it just after posting it in the forum. thanks very much.

Brian Agnew · Accepted Answer · 2012-08-06 08:47:50Z

0

It looks to me like you're performing the reverse twice.

That is, you swap the beginning and end elements immediately, and at the end of your iteration you swap them again. i.e. you end up with the same array.

You can either:

perform your swap only halfway through your array, or
populate a second array in reverse from the first (I don't know if you want to repopulate the original array, however - you may need to copy it back in)

answered Aug 6, 2012 at 8:47

Brian Agnew

273k38 gold badges342 silver badges443 bronze badges

Comments

Boris Ivanov · Accepted Answer · 2012-08-06 08:55:03Z

0

There no problem with array. Problem with your algo. //reversing an array using function

#include<stdio.h>
void rev(int array[],int length)
{
    int k,j,temp;
    for(k=length-1,j=0;k>=0 && j<length / 2; k--,j++){
        temp=array[k];
        array[k]=array[j];
        array[j]=temp;
    }
}

This reverse array. Your algo reverse it twice. So just add /2 in for conditions.

answered Aug 6, 2012 at 8:55

Boris Ivanov

4,2541 gold badge35 silver badges42 bronze badges

Collectives™ on Stack Overflow

using array as function parameter

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related