Rails 3.1 / Ruby - Nested loops?

Question

I'm having some trouble with nested loops. Does anyone know a better way of doing this:

@product.tracks.each do |t|
    t.artists_tracks.each do |at|
        at.role = at.artist.role
        at.position = at.artist.position
        at.save
    end
end

I'm getting an undefined method role = error

Thanks in advance

Loop looks good to me. What attributes to you have on each models? — Dogbert
– Dogbert, Commented Aug 7, 2012 at 14:00

Alexandre Abreu · Accepted Answer · 2012-08-07 14:04:16Z

1

@product.tracks.each do |track|
    track.artists_tracks.each do |at|
        at.role = track.artist.role
        at.position = track.artist.position
        at.save
    end
end

But yeah.. sure thing you need to review your models attrs

answered Aug 7, 2012 at 14:04

Alexandre Abreu

1,4372 gold badges14 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tokland · Accepted Answer · 2012-08-07 14:01:16Z

0

Some comments:

You should be able to write @product.artist_tracks provided you have a has_many :artist_tracks, :through => :artists.
at.role = at.artist.role. You are breaking the basic SQL rule of not having data duplicated, let the artist have the role.

answered Aug 7, 2012 at 14:01

tokland

68.2k13 gold badges151 silver badges174 bronze badges

Collectives™ on Stack Overflow

Rails 3.1 / Ruby - Nested loops?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related