Javascript not displaying in browser

Question

I'm following a tutorial about creating a timer in JavaScript but I can't get it to show up on my browser. I'm using Dreamweaver and it shows the timer just fine in a "live view" but in the browser window nothing is being displayed. What am I missing?

This is the main HTML page:

<html>
    <head>
        <script type="text/javascript" src="/Timer2.js" />
    </head>
    <body>
        <div id='timer' />
        <script type="text/javascript">
            window.onload = CreateTimer("timer", 90);
        </script>
    </head>
    </body>
</html>

This is the JavaScript timer function. timer2.js:

var Timer;
var TotalSeconds;

function CreateTimer(TimerID, Time) {
    Timer = document.getElementById(TimerID);
    TotalSeconds = Time;

    UpdateTimer()
    window.setTimeout("Tick()", 1000);
}

function Tick() {
    if (TotalSeconds <= 0) {
        alert("Time's up!")
        return;
    }

    TotalSeconds -= 1;
    UpdateTimer()
    window.setTimeout("Tick()", 1000);
}

function UpdateTimer() {
    Timer.innerHTML = TotalSeconds;
}

function UpdateTimer() {
    var Seconds = TotalSeconds;

    var Days = Math.floor(Seconds / 86400);
    Seconds -= Days * 86400;

    var Hours = Math.floor(Seconds / 3600);
    Seconds -= Hours * (3600);

    var Minutes = Math.floor(Seconds / 60);
    Seconds -= Minutes * (60);

    var TimeStr = ((Days > 0) ? Days + " days " : "") + LeadingZero(Hours) + ":" + LeadingZero(Minutes) + ":" + LeadingZero(Seconds)

    Timer.innerHTML = TimeStr ;
}


function LeadingZero(Time) {
    return (Time < 10) ? "0" + Time : + Time;
}

first <div id='timer' /> should be <div id='timer' ></div> — unloco
– unloco, Commented Aug 8, 2012 at 23:00
Are you using your browser's console to see what errors your script is genrating? — Greg Rozmarynowycz
– Greg Rozmarynowycz, Commented Aug 8, 2012 at 23:19

Niet the Dark Absol · Accepted Answer · 2012-08-08 22:59:29Z

4

You can't self-close a script tag. You MUST write <script ....></script>

answered Aug 8, 2012 at 22:59

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

ndequeker Over a year ago

yes it is self-closed, but you better don't do that. See stackoverflow.com/questions/4531772/…

Undermine2k Over a year ago

Ok I changed it but this still does not fix the display problem in the browser.

Niet the Dark Absol Over a year ago

Well there's at least 10 different things wrong with your code. Did you write that, and if so who taught you?

Undermine2k Over a year ago

forum.codecall.net/topic/…

Niet the Dark Absol Over a year ago

Well the person who wrote that is a dunce and should not be listened to. Never EVER put a string in setTimeout. ALWAYS put a semicolon at the end of a "line". AVOID global variables. Don't rely on the timer being accurate (use delta timing where possible). Identifiers stating with an uppercase letter should be reserved for instanciable object names. You are defining the same function twice. You are using innerHTML when nodeValue (on a text node in the element) would be more appropriate. You are repeatedly calling setTimeout to simulate what setInterval does for you. And so on...

|

p0ulp3 · Accepted Answer · 2012-08-08 23:20:13Z

1

Write <div id="timer"></div> and no <div id='timer' />

Delete your </head> at the bottom of the code, and if your script doesn't work again, try src="Timer2.js" without the "/"

edited Aug 8, 2012 at 23:20

answered Aug 8, 2012 at 23:05

p0ulp3

315 bronze badges

Collectives™ on Stack Overflow

Javascript not displaying in browser

2 Answers 2

7 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related