Javascript object method does not update variable

Question

var myUser = (function () {
    var username = "",
    var isConnected = false;
    return {
        setUsername: function (n) {
            username = n;
        },
        setConn: function (connStatus) {
            isConnected = connStatus;
        },
        user: username,
        isCon: isConnected
    };
}());

When I call

myUser.setUsername("user123");

username variable does not get updated.

Any advice?

Probably just a typo, but missing a ; on the var username = "" line... Have you tried this.username = n instead, so you're setting the object's own username member, and not some random variable whose name happens to be the same? — Marc B
– Marc B, Commented Aug 13, 2012 at 2:08

su- · Accepted Answer · 2012-08-13 02:29:51Z

3

It looks like you want to use myUser.user to refer the updated username value. However, if that's the case, it doesn't work. setUsername updates username variable, but myUser.user only points to username's initial value, which is "". It won't points to the updated username value

to fix the problem, you can change

user: username,

to

user: function() {
    return username;
},

edited Aug 13, 2012 at 2:29

answered Aug 13, 2012 at 2:20

su-

3,1763 gold badges34 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

bfavaretto Over a year ago

Exactly. To the asker: please note that the connection getter and setter have to be reworked as well, according to the same logic. Also, setConn is currently introducing a global variable isConn (typo?)

gotta have my pops Over a year ago

Yes, sorry, that's a typo, I changed the variable names when copying pasting here.

elclanrs · Accepted Answer · 2012-08-13 02:17:29Z

1

This might be a better case to use prototype model:

function User(prop) {
  prop = prop || {};
  this.username = prop.username || '';
  this.isConnected = prop.isConnected || false;
}
User.prototype = {
  setUser: function(uname) { this.username = uname; },
  setConn: function(status) { this.isConnected = status; }
};

var myUser = new User();
myUser.setUser('user1234');
// OR
var myUser = new User({ username: 'user1234' });

console.log(myUser.username); //=> 'user1234'

answered Aug 13, 2012 at 2:17

elclanrs

94.2k21 gold badges137 silver badges171 bronze badges

2 Comments

gotta have my pops Over a year ago

what does prop = prop || {} do?

elclanrs Over a year ago

it just makes sure that prop is not undefined. It means if there's no prop then use an empty object

xiaowl · Accepted Answer · 2012-08-13 02:23:41Z

0

    ....
    },
    user: username,
    isCon: isConnected

user: username forces the username to be evaluated, which returns "". This is more easy to figure out what happend

   var obj = {
        log: console.log("printed when init")
   }

answered Aug 13, 2012 at 2:23

xiaowl

5,2273 gold badges29 silver badges29 bronze badges

Collectives™ on Stack Overflow

Javascript object method does not update variable

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related