ArrayList inside a method/constructor - Java

Question

After search around google I couldn't find a answer for that, I'm not too familiar to Java, I use C# most of the time and I know that using C# it is possible to do and probably it is in Java.

Ps: Sorry the Highlight, I don't know how to use that here.

I have a constructor:

public WeaponsData(ArrayList<NPC> _drop, ArrayList<NPC> _buy, ArrayList<NPC> _sell) { }

Then when I try to create the Object creating the ArrayLists() directly on it, it doesn't work:

public static WeaponsData AngelicAxe = new WeaponsData(new ArrayList<NPC>() { new NPC("Rat", "None", 0), new NPC("Dog", "None", 0) },
                new ArrayList<NPC>() { new NPC("Player", "All", 0) },
                new ArrayList<NPC>() { new NPC("Cain", "First", 5000) }
                );

There is no way to do that on Java?

Thank you

stackoverflow.com/questions/1005073/…

Colin D
– Colin D

2012-08-27 15:04:36 +00:00
Commented Aug 27, 2012 at 15:04 — Colin D
– Colin D, Commented Aug 27, 2012 at 15:04

Sean Patrick Floyd · Accepted Answer · 2012-08-27 15:03:22Z

6

ArrayList does not have the constructors necessary to do that. You can either wrap the arguments in a call to Arrays.asList():

public static WeaponsData AngelicAxe = new WeaponsData(
    new ArrayList<NPC>(
       Arrays.asList(
          new NPC("Rat", "None", 0),
          new NPC("Dog", "None", 0)
       )
    ),
// etc
);

or use the factory methods provided by the Guava Framework:

public static WeaponsData AngelicAxe = new WeaponsData(
    Lists.newArrayList(
        new NPC("Rat", "None", 0),
        new NPC("Dog", "None", 0)
    ),
// etc.
);

Of course, if you use Guava, you should probably use an immutable collection instead, as you are apparently trying to implement a constant:

public static final WeaponsData ANGELIC_AXE = new WeaponsData(
    ImmutableList.of(
        new NPC("Rat", "None", 0),
        new NPC("Dog", "None", 0)
    ),
// etc.
);

edited Aug 27, 2012 at 15:03

answered Aug 27, 2012 at 14:57

Sean Patrick Floyd

301k72 gold badges481 silver badges598 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Donald Raab · Accepted Answer · 2019-11-09 23:46:01Z

2

If you are using Eclipse Collections, you can use the FastList implementation to create a list. FastList implements java.util.List as well as richer Eclipse Collections specific types. It can be used as a drop in replacement for ArrayList, if you don't mind it not supporting modCount. Your code would look as follows using FastList.

public static WeaponsData AngelicAxe = new WeaponsData( 
    FastList.newListWith( 
          new NPC("Rat", "None", 0), 
          new NPC("Dog", "None", 0) 
    ), 
// etc 
);

Note: I am a committer for Eclipse Collections

edited Nov 9, 2019 at 23:46

answered Sep 6, 2012 at 15:26

Donald Raab

6,8362 gold badges40 silver badges47 bronze badges

Comments

ollo · Accepted Answer · 2012-08-27 15:00:45Z

1

Try this:

new ArrayList<NPC>(Arrays.asList(new NPC[] { new NPC("Rat", "None", 0), new NPC("Dog", "None", 0)}))

--> creates an Array of NPC's and makes a list out of it

answered Aug 27, 2012 at 15:00

ollo

25.5k15 gold badges112 silver badges158 bronze badges

Comments

kosa · Accepted Answer · 2012-08-27 15:03:59Z

1

You need to call add on arraylist to add elements.

ArrayList doesn't have constructor with custom object.

Example:

new ArrayList<NPC>().add( new NPC("Player", "All", 0));

EDIT: If chaining of add is the requirement, then Arrays.asList(..) need to be used.

edited Aug 27, 2012 at 15:03

answered Aug 27, 2012 at 14:57

kosa

66.7k15 gold badges134 silver badges170 bronze badges

1 Comment

Colin D Over a year ago

the add method does not allow for chaining add calls, which the op would want; in the example he is trying to create a list with more than 1 element.

Dan D. · Accepted Answer · 2012-08-27 14:59:12Z

0

The stuff you tried can be done for arrays of data, but not for ArrayList

This works:

new NPC[] {new NPC(...)};

This doesn't:

new ArrayList<NPC>() {new NPC(...)};

answered Aug 27, 2012 at 14:59

Dan D.

32.4k6 gold badges66 silver badges81 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:59:26Z

0

Aside from Arrays.asList() you can also use double brace initialization:

ArrayList<NPC> list = new ArrayList<NPC>() {{
    add(new NPC("Rat", "None", 0));
    add(new NPC("Dog", "None", 0));
}};

edited May 23, 2017 at 11:59

CommunityBot

11 silver badge

answered Aug 27, 2012 at 15:00

Justin Muller

1,30313 silver badges22 bronze badges

1 Comment

Sean Patrick Floyd Over a year ago

Can, but shouldn't. It's a nice trick to know, but a terrible coding practice!

Woot4Moo · Accepted Answer · 2012-08-27 15:01:04Z

0

Couple of things style + flexibility:

public WeaponsData(ArrayList<NPC> _drop, ArrayList<NPC> _buy, ArrayList<NPC> _sell) { }

should be:

public WeaponsData(Collection<NPC> drops, Collection<NBC> buys, Collection<NPC> sells)  {}

To populate the Collection use

 Collection.add(element);

If you want to use the syntax of { foo,bar,baz} use an array. Like so:

NPC[] npcs = new NPC[] {foo,bar,bax};

you can then do Arrays.asList(npcs) to bring it back into a List

answered Aug 27, 2012 at 15:01

Woot4Moo

24.4k19 gold badges103 silver badges156 bronze badges

Comments

Strelok · Accepted Answer · 2012-08-27 15:04:40Z

Inline initializers like that are not supported in Java by default. Java has something that "looks" similar, but it's not exactly the same.

Here is how you can define an ArrayList inline (using a technique called "double brace initialisation"):

ArrayList<NPC> npcs = new ArrayList<NPC>()
{ {
   add(new NPC());
   add(new NPC());
}};

As you can see, not very nice. You're also actually creating an instance of a subclass of the ArrayList instead of an ArrayList class.

In Java it is customary to just use the List<T> type to define you variables, so you can use any List implementation.

Consider this instead:

public WeaponsData(List<NPC> _drop, List<NPC> _buy, List<NPC> _sell) { }

Then you can do:

public static WeaponsData AngelicAxe = new WeaponsData(
  Arrays.asList( new NPC("Rat", "None", 0), new NPC("Dog", "None", 0) ),
  Arrays.asList( new NPC("Player", "All", 0) ),
  Arrays.asList( new NPC("Cain", "First", 5000) ) );

There is also a Google Guava set of libraries that has a very nice collections library with lots of helper methods that aid in collection creation and manipulation:

Check it out: http://code.google.com/p/guava-libraries/ and the User Guide

Collectives™ on Stack Overflow

ArrayList inside a method/constructor - Java

8 Answers 8

Comments

Comments

Comments

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

Comments

Comments

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related