String Split()-method

Question

Why am I getting this error?

public class ParameterParser
{
    public List<string> ParseParameter(string queryString)
    {
        queryString = queryString.Replace(" ", "");

        string[] strs = queryString.Split(@"(", @"=", @",", @"<>", 
                                          StringSplitOptions.None);

        List<string> parameters = new List<string>();

        foreach (string ss in strs)
        {
            string s = ss.Trim(')');

            if (s.StartsWith("@") && !s.Equals("") && s!=null)
            {
                parameters.Add(s.Replace(" ", ""));
            }
        }

        return parameters;
    }
}

Error 3 The best overloaded method match for 'string.Split(params char[])' has some invalid arguments F:...\ParameterParser.cs

Lucas Jones · Accepted Answer · 2009-08-01 11:44:01Z

6

If you want to pass an array of strings, you have to do that explicitly:

string[] strs = queryString.Split(new string[] {"(", "=", ",", "<>"}, 
                                  StringSplitOptions.None);

I suspect you were modelling your code on something like this:

string[] strs = queryString.Split('(', '=', ',');

This is using a parameter array (the params modifier in C#). Parameter arrays are only applicable for the final parameter, and no overload of String.Split takes a params string[]. That's why it wasn't working for you.

Note that I've changed the strings into simple string literals - I would recommend only using verbatim string literals when you actually need to.

edited Aug 1, 2009 at 11:44

Lucas Jones

20.3k9 gold badges77 silver badges89 bronze badges

answered Aug 1, 2009 at 11:24

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mitch Wheat · Accepted Answer · 2009-08-01 11:34:06Z

0

@"(", @"=", @",", @"<>" is not a single string or a char[] array

Try this:

string[] strs = queryString.Split(new string[] {@"(", @"=",@",",@"<>" },StringSplitOptions.None);

edited Aug 1, 2009 at 11:34

answered Aug 1, 2009 at 11:24

Mitch Wheat

302k44 gold badges482 silver badges552 bronze badges

2 Comments

Jon Skeet Over a year ago

It doesn't have to be - see msdn.microsoft.com/en-us/library/tabh47cf.aspx

Mitch Wheat Over a year ago

I didn't say that it did I just said it wasn't! ;)

Collectives™ on Stack Overflow

String Split()-method

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related