return values from class php oop

Question

the code is as follow:

Class userinfo {
    function fetchdatabyemail($email) {
        $result=mysql_query(" SELECT * FROM users WHERE email='$email'"); 
        while($row = mysql_fetch_array($result)) {
            $name = $row['name'];
            $num = $row['num'];
            $city = $row['city'];
        }
        $numrows= mysql_num_rows($result);    
    }
}

now to get the info I do this :

$info = new userinfo();
$info->fetchdatabyemail('[email protected]');  
echo $info->city;

and it doesnt return the info. I think Im doing something wrong any ideas please

xkeshav · Accepted Answer · 2012-08-31 05:23:57Z

5

do it

public $numrows;
public function fetchDataByEmail($email) {
        $result=mysql_query(" SELECT * FROM users WHERE email='$email'"); 
        while($row = mysql_fetch_assoc($result)) {
        $fetch[] = $row;
        }
        $this->numrows = mysql_num_rows($result);  
        return $fetch;  
}

then

$info = new userinfo();
$detail = $info->fetchDataByEmail('[email protected]');  
print_r($detail); // return all result array
$info->numrows; // will return number of rows.

edited Aug 31, 2012 at 5:23

answered Aug 31, 2012 at 5:18

xkeshav

54.2k47 gold badges183 silver badges255 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chanon · Accepted Answer · 2012-08-31 05:18:09Z

2

Your variable working locally. You need to assign it in class level. Your code should be:

Class userinfo {

public $name,$city,$num,$numrows;

function fetchdatabyemail($email) {
$result=mysql_query(" SELECT * FROM users WHERE email='$email'"); 
while($row = mysql_fetch_array($result)) {
$this->name = $row['name'];
$this->num = $row['num'];
$this->city = $row['city'];
}
$this->numrows= mysql_num_rows($result);

}

Then get to the info using this:

$info = new userinfo();
$info->fetchdatabyemail('[email protected]');  
echo $info->city;

}

answered Aug 31, 2012 at 5:18

Chanon

4761 gold badge5 silver badges12 bronze badges

Comments

user1393876 · Accepted Answer · 2012-08-31 05:19:38Z

1

You should have a private variable and getter/setter for it (this is the proper way, see code below). You could also declare $city as a public variable and access directly to it from the class' instance.

class userinfo
{
    private $city = '';

    public function getCity()
    {
        return $this->city;
    }

    public function fetchDataByEmail($email)
    {
        // Your code here
        $this->city = $row['city'];
    }
}

$info = new userinfo();
$info->fetchDataByEmail('[email protected]');
echo 'City: '.$this->getCity();

answered Aug 31, 2012 at 5:19

user1393876

531 gold badge1 silver badge4 bronze badges

Comments

shaunhusain · Accepted Answer · 2012-08-31 16:42:38Z

1

I think your problem is the scope/visbility of your variables think you need to declare them outside of the scope of the function:

http://www.php.net/manual/en/language.oop5.visibility.php

class userinfo {
    public $name;
    public $num;
    public $city;
    public $numrows;
    function fetchdatabyemail($email) {
        $result=mysql_query(" SELECT * FROM users WHERE email='$email'"); 
        while($row = mysql_fetch_array($result)) {
            this->$name = $row['name'];
            this->$num = $row['num'];
            this->$city = $row['city'];
        }
        this->$numrows= mysql_num_rows($result);
    }
}

edited Aug 31, 2012 at 16:42

answered Aug 31, 2012 at 5:16

shaunhusain

19.7k4 gold badges41 silver badges53 bronze badges

Comments

Michael Wheeler · Accepted Answer · 2012-08-31 05:19:10Z

0

You need to first declare the class variables.

class Userinfo {

    $city;

    // then declare the function

}

The way you were doing it, the scope of $city was only within the function, not stored as a field

answered Aug 31, 2012 at 5:19

Michael Wheeler

6607 silver badges11 bronze badges

1 Comment

cppit Over a year ago

needs to declare if its private or public or protected :)

Mansoor Jafar · Accepted Answer · 2012-08-31 05:24:32Z

0

while loop in each iteration is updating info. so, u can echo in the while like

function fetchdatabyemail($email) {
    $result=mysql_query(" SELECT * FROM users WHERE email='$email'"); 
    while($row = mysql_fetch_array($result)) {
       echo $row['city'];
    }

or can store values in an array which is globally declared in the class and than echo the array.

in your code you have $city declared with local function scope which is not accessible from class $info->city.

answered Aug 31, 2012 at 5:24

Mansoor Jafar

1,5083 gold badges15 silver badges32 bronze badges

Collectives™ on Stack Overflow

return values from class php oop

6 Answers 6

Comments

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related