Apostrophes in jquery/javascript string

Question

I have the following code which appends an icon with an alert after the <a> tag :

$j("li[name='"+node_name+"'] > a").after('<a onmouseover="alert(\' expnote_from_db[n][0] \');" ><ins class="' + selected_class + '">&nbsp;</ins></a>');

The code above works fine except that it displays exp_from_db[n][0] as a string inside the alert box.

So I changed it to the code below but nothing is displayed now

  $j("li[name='"+node_name+"'] > a").after('<a onmouseover="alert(\'"'+ expnote_from_db[n][0] + '"\');" ><ins class="' + selected_class + '">&nbsp;</ins></a>');

I don't understand where did I go wrong with the apostrophes.

I would appreciate your help regarding this. Thanks

"alert(\' expnote_from_db[n][0] \');" should look like "alert(\'' + expnote_from_db[n][0] + '\');" — vol7ron
– vol7ron, Commented Aug 31, 2012 at 14:07

amd · Accepted Answer · 2012-08-31 13:56:13Z

3

This should work

$j('li[name="'+node_name+'"] > a')
    .after('<a onmouseover="alert(\''+ expnote_from_db[n][0] + '\')" ><ins class="' + selected_class + '">&nbsp;</ins></a>');

answered Aug 31, 2012 at 13:56

amd

21.7k6 gold badges54 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Quentin · Accepted Answer · 2012-08-31 13:48:28Z

3

The " characters are delimiting the HTML attribute. You are terminating that attribute prematurely.

<a onmouseover="alert(\'"

Nesting JavaScript in HTML attributes is a pain.

Nesting JavaScript in HTML attributes in JavaScript strings is a bigger pain.

Don't do it. Apply event handlers using addEventListener and friends (since you are using jQuery that means using the on method which abstracts them).

answered Aug 31, 2012 at 13:48

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Collectives™ on Stack Overflow

Apostrophes in jquery/javascript string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related