javascript var from php too long

Question

in this code I pass a PHP var to javascrip to display it in a div element. When the string in less than 50 char it works nice but when it is a little bit longen it crashes. here is my code:

$sql3 = "SELECT * FROM $table2 WHERE id = '$newsId'";
$result3 = mysql_query($sql3);
$thisNews = mysql_fetch_array($result3);
?>
newsContent = "<? echo $thisNews['news']; ?>";

newsDiv  = "<div class='newsBox'>";
newsDiv += "<div class='newsTitle'><? echo $rowArray[$i]['title']; ?></div>";
newsDiv += "<div class='newsBody'>"+newsContent+"</div>";
newsDiv += "<div class='newsFoot'>autor: <? echo $thisNews['author']; ?> - <? echo $thisNews['site']; ?> - <? echo $thisNews['source']; ?></div>";
box.append(newsDiv);

Are there possibly linefeeds or special characters, quotes etc in the db output? — jtheman
– jtheman, Commented Sep 2, 2012 at 14:27

lanzz · Accepted Answer · 2012-09-02 18:47:23Z

1

Better approach would be newsContent = <?php echo json_encode($thisNews['news']); ?>; — that would take care of encoding any special characters in the string, like quote marks that would terminate your JS string and drop you into code context for the remaining of the string, which is not a good thing.

answered Sep 2, 2012 at 18:47

lanzz

43.4k12 gold badges93 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ignacio Vazquez-Abrams Over a year ago

And the especially nasty string </script>.

Collectives™ on Stack Overflow

javascript var from php too long

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related